feat(lint): add stylelint overrides and variation files #2593
Conversation
This reverts commit a47fe14.
(^ /\*.*(?<!\*/)\n)
|
What about renaming (in another PR) |
This would possibly break tons of existing projects dealing with custom themes . I would not dare to do that for FUI 2.x |
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
ko2in,
lubber-de and
prudho
very valid argument 👍 PR is complete, minified css hash is the same |
| @@ -16,5 +16,5 @@ | |||
|
|
|||
| @flags: { | |||
| }; | |||
| @size-map: { | |||
| }; | |||
There was a problem hiding this comment.
Dont remove the semicolon here, to support PHP LESS port
There was a problem hiding this comment.
I was removed by no-missing-end-of-source-newline rule, not sure why, checking
There was a problem hiding this comment.
I can confirm this was removed by c877b76 autofix, when the rule is fixed manually, the semicolon stays. Other fixes by no-missing-end-of-source-newline are fine (no semicolon removed).
mvorisek
force-pushed
the
more_stylelint
branch
from
8253ac7 to
068b55c
Compare
lubber-de
changed the title
lubber-de
added
lang/css
Compared to Stylelint, Prettier is very simple tool and I am quite supprised Stylelint is deprecating the whitespace rules in favor of Prettier. For LESS it seems ok, for JS, we should never enable Prettier as formatting is part of a code and improves readability. As Prettier is an opinionated formatter instead of an linter, we need to satisfy it everywhere without exceptions. When I was crafting this PR, I found several Prettier issues and proposed changes to Prettier: Fix semicolon duplicated at the end of LESS file prettier/prettier#14007 Fix no space after unary minus when followed by opening parenthesis in LESS prettier/prettier#14008 Do not change case of property name if inside a variable declaration in LESS prettier/prettier#14034 In this PR, these changes are contained and Prettier is patched before it is run. Once the changes are merged in prettier and stable release is made, they can be removed. This PR fixes minor whitespaces unfixed/undetected in GH-2610. And also asserts: PHP port of the LESS fails to compile colors.less #1832 feat(lint): add stylelint overrides and variation files #2593 (comment) Prettier has no built in support to dump the diff - prettier/prettier#6885 - so we dump it in the CI using git.
In #2592 I completely missed there are also LESS files named with
*.overridesand*.variablesextensions, so these LESS files are fixed in this PR. As in #2592, only whitespaces are fixed, no functional change.