-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): unify/simplify typeof operator usage #2599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
Unify typeof operator usage
Unify/simplify typeof operator usage
Dec 11, 2022
mvorisek
force-pushed
the
airbnb_part4
branch
from
December 12, 2022 07:28
c2134be
to
10085c1
Compare
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
ko2in,
lubber-de and
prudho
December 12, 2022 07:28
(typeof \w+ [=!]=)( '\w+')
(typeof .* [=!]=)( '\w+')
mvorisek
force-pushed
the
airbnb_part4
branch
from
December 12, 2022 08:17
10085c1
to
c4c6954
Compare
lubber-de
reviewed
Dec 12, 2022
lubber-de
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lubber-de
changed the title
Unify/simplify typeof operator usage
feat(lint): unify/simplify typeof operator usage
Dec 12, 2022
lubber-de
added
type/feat
Any feature requests or improvements
type/lint
eslint / stylelint related changes only
labels
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing
unicorn/no-typeof-undefined
rule with some related changes done manually