Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): unify/simplify typeof operator usage #2599

Merged
merged 16 commits into from
Dec 12, 2022
Merged

feat(lint): unify/simplify typeof operator usage #2599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
80df463
strictly autofix no-var for non src/* files only
mvorisek Dec 7, 2022
7bd2e54
simplify cond
mvorisek Dec 11, 2022
117dc67
fix "configConst" and mutating imported config
mvorisek Dec 11, 2022
8afdfda
Revert "revert tasks/ changes"
mvorisek Dec 11, 2022
ca4ba59
Merge remote-tracking branch 'fomantic/develop' into airbnb_part2
mvorisek Dec 11, 2022
4889d17
Merge branch 'develop' into airbnb_part2
mvorisek Dec 12, 2022
23de6fa
fix config order
mvorisek Dec 12, 2022
d2e3f06
strictly autofix all rare errors
mvorisek Dec 7, 2022
836aef7
fix all rare errors manually
mvorisek Dec 7, 2022
62b670c
replace typeof [=!] to strict cmp with regex
mvorisek Dec 7, 2022
804f6cc
replace remaining manually
mvorisek Dec 7, 2022
43c0b27
strictly autofix unicorn/no-typeof-undefined
mvorisek Dec 7, 2022
db05c68
fix remaining 'undefined' manually
mvorisek Dec 7, 2022
c4c6954
fix eqeqeq for xxx.Math == Math using regex
mvorisek Dec 7, 2022
6020e7d
Merge branch 'develop' into airbnb_part4
mvorisek Dec 12, 2022
801cdc1
fix possibly undeclared variable undefined check
mvorisek Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ module.exports = {
'unicorn/no-hex-escape': 'off',
'unicorn/no-instanceof-array': 'off',
'unicorn/no-process-exit': 'off',
'unicorn/no-typeof-undefined': 'off',
'unicorn/no-useless-switch-case': 'off',
'unicorn/no-useless-undefined': 'off',
'unicorn/prefer-array-find': 'off',
Expand Down
12 changes: 6 additions & 6 deletions src/definitions/behaviors/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -34,7 +34,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),

returnedValue
Expand Down Expand Up @@ -126,7 +126,7 @@

decode: {
json: function (response) {
if (response !== undefined && typeof response == 'string') {
if (response !== undefined && typeof response === 'string') {
try {
response = JSON.parse(response);
} catch (e) {
Expand Down Expand Up @@ -431,8 +431,8 @@

if (useFormDataApi) {
formData = new FormData($form[0]);
settings.processData = typeof settings.processData !== 'undefined' ? settings.processData : false;
settings.contentType = typeof settings.contentType !== 'undefined' ? settings.contentType : false;
settings.processData = settings.processData !== undefined ? settings.processData : false;
settings.contentType = settings.contentType !== undefined ? settings.contentType : false;
} else {
var
formArray = $form.serializeArray(),
Expand Down Expand Up @@ -1000,7 +1000,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
26 changes: 13 additions & 13 deletions src/definitions/behaviors/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -29,7 +29,7 @@

query = arguments[0],
legacyParameters = arguments[1],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),
returnedValue
;
Expand Down Expand Up @@ -302,7 +302,7 @@
},
// duck type rule test
shorthandRules: function (rules) {
return (typeof rules == 'string' || Array.isArray(rules));
return (typeof rules === 'string' || Array.isArray(rules));
},
empty: function ($field) {
if (!$field || $field.length === 0) {
Expand Down Expand Up @@ -507,7 +507,7 @@
if (!Array.isArray(rules) && typeof rules === 'object') {
fullFields[name] = rules;
} else {
if (typeof rules == 'string') {
if (typeof rules === 'string') {
rules = [rules];
}
fullFields[name] = {
Expand Down Expand Up @@ -873,7 +873,7 @@
$prompt = $fieldGroup.children(selector.prompt),
promptExists = ($prompt.length !== 0)
;
errors = (typeof errors == 'string')
errors = (typeof errors === 'string')
? [errors]
: errors;
module.verbose('Adding field error state', identifier);
Expand Down Expand Up @@ -1229,7 +1229,7 @@
showErrors = (showErrors !== undefined)
? showErrors
: true;
if (typeof field == 'string') {
if (typeof field === 'string') {
module.verbose('Validating field', field);
fieldName = field;
field = validation[field];
Expand Down Expand Up @@ -1436,7 +1436,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down Expand Up @@ -1732,7 +1732,7 @@
return $.fn.form.settings.rules.range(value, range, 'integer');
},
range: function (value, range, regExp) {
if (typeof regExp == 'string') {
if (typeof regExp === 'string') {
regExp = $.fn.form.settings.regExp[regExp];
}
if (!(regExp instanceof RegExp)) {
Expand Down Expand Up @@ -1778,10 +1778,10 @@

// is value (case insensitive)
is: function (value, text) {
text = (typeof text == 'string')
text = (typeof text === 'string')
? text.toLowerCase()
: text;
value = (typeof value == 'string')
value = (typeof value === 'string')
? value.toLowerCase()
: value;

Expand All @@ -1795,10 +1795,10 @@

// value is not another value (case insensitive)
not: function (value, notValue) {
value = (typeof value == 'string')
value = (typeof value === 'string')
? value.toLowerCase()
: value;
notValue = (typeof notValue == 'string')
notValue = (typeof notValue === 'string')
? notValue.toLowerCase()
: notValue;

Expand Down Expand Up @@ -1952,7 +1952,7 @@
},
valid = {},
validCard = false,
requiredTypes = (typeof cardTypes == 'string')
requiredTypes = (typeof cardTypes === 'string')
? cardTypes.split(',')
: false,
unionPay,
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/behaviors/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -29,7 +29,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),

returnedValue
Expand Down Expand Up @@ -515,7 +515,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/behaviors/visibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -28,7 +28,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),
returnedValue,

Expand Down Expand Up @@ -1123,7 +1123,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
10 changes: 5 additions & 5 deletions src/definitions/globals/site.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (window !== undefined && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -25,7 +25,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),

settings = ($.isPlainObject(parameters))
Expand Down Expand Up @@ -71,13 +71,13 @@
module.verbose('Console not available, normalizing events');
module.disable.console();
}
if (typeof console.group == 'undefined' || typeof console.groupEnd == 'undefined' || typeof console.groupCollapsed == 'undefined') {
if (console.group === undefined || console.groupEnd === undefined || console.groupCollapsed === undefined) {
module.verbose('Console group not available, normalizing events');
window.console.group = function () {};
window.console.groupEnd = function () {};
window.console.groupCollapsed = function () {};
}
if (typeof console.markTimeline == 'undefined') {
if (console.markTimeline === undefined) {
module.verbose('Mark timeline not available, normalizing events');
window.console.markTimeline = function () {};
}
Expand Down Expand Up @@ -357,7 +357,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/modules/accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -27,7 +27,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),

returnedValue
Expand Down Expand Up @@ -478,7 +478,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/modules/calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -30,7 +30,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),
returnedValue,
timeGapTable = {
Expand Down Expand Up @@ -1486,7 +1486,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
8 changes: 4 additions & 4 deletions src/definitions/modules/checkbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -28,7 +28,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),
returnedValue
;
Expand Down Expand Up @@ -166,7 +166,7 @@
},

preventDefaultOnInputTarget: function () {
if (typeof event !== 'undefined' && event !== null && $(event.target).is(selector.input)) {
if (event !== undefined && event !== null && $(event.target).is(selector.input)) {
module.verbose('Preventing default check action after manual check action');
event.preventDefault();
}
Expand Down Expand Up @@ -763,7 +763,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/modules/dimmer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
return typeof obj === 'function' && typeof obj.nodeType !== 'number';
}

window = (typeof window != 'undefined' && window.Math == Math)
window = (window !== undefined && window.Math === Math)
? window
: globalThis;

Expand All @@ -27,7 +27,7 @@
performance = [],

query = arguments[0],
methodInvoked = (typeof query == 'string'),
methodInvoked = (typeof query === 'string'),
queryArguments = [].slice.call(arguments, 1),

returnedValue
Expand Down Expand Up @@ -573,7 +573,7 @@
;
passedArguments = passedArguments || queryArguments;
context = context || element;
if (typeof query == 'string' && object !== undefined) {
if (typeof query === 'string' && object !== undefined) {
query = query.split(/[\. ]/);
maxDepth = query.length - 1;
$.each(query, function (depth, value) {
Expand Down
Loading