Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): fix various eslint rules #2607

Merged
merged 60 commits into from
Dec 12, 2022
Merged

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 12, 2022

Modernize code using eslint advisory introduced in GH-2596. This PR fixes several smaller rules not worth a separate PRs.

(typeof .* [=!]=)( '\w+')
(?<!\w)(if|else).* \{\n
(\}) (if \(.* \{)
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title Fix various eslint rules feat(lint): fix various eslint rules Dec 12, 2022
@lubber-de lubber-de merged commit 27384cb into fomantic:develop Dec 12, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 12, 2022
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript type/ci Anything related to CI/CD type/lint eslint / stylelint related changes only labels Dec 12, 2022
@mvorisek mvorisek deleted the airbnb_part7 branch December 12, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/ci Anything related to CI/CD type/feat Any feature requests or improvements type/lint eslint / stylelint related changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants