feat(lint): fix various eslint rules

.eslintrc.js

@@ -80,6 +80,7 @@ module.exports = {
         'unicorn/no-null': 'off',
         'unicorn/no-this-assignment': 'off',
         'unicorn/numeric-separators-style': 'off',
+        'unicorn/prefer-array-find': 'off',
         'unicorn/prefer-array-some': 'off', // https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2007
         'unicorn/prefer-module': 'off',
         'unicorn/prevent-abbreviations': 'off',
@@ -118,32 +119,10 @@ module.exports = {
         'unicorn/no-nested-ternary': 'off', // about 80 errors (except 14 nested ternary operators autofixable)
 
         // TODO
-        'no-bitwise': 'off',
-        'no-cond-assign': 'off',
-        'no-empty': 'off',
-        'no-labels': 'off',
-        'no-loop-func': 'off',
-        'no-new-func': 'off',
-        'no-path-concat': 'off',
-        'no-prototype-builtins': 'off',
         'no-return-assign': 'off',
-        'no-self-assign': 'off',
         'no-shadow-restricted-names': 'off',
-        'no-unused-expressions': 'off',
         'no-use-before-define': 'off',
-        'unicorn/empty-brace-spaces': 'off',
-        'unicorn/escape-case': 'off',
-        'unicorn/new-for-builtins': 'off',
-        'unicorn/no-hex-escape': 'off',
-        'unicorn/no-instanceof-array': 'off',
-        'unicorn/no-process-exit': 'off',
-        'unicorn/no-useless-switch-case': 'off',
-        'unicorn/no-useless-undefined': 'off',
-        'unicorn/prefer-array-find': 'off',
-        'unicorn/prefer-default-parameters': 'off',
-        'unicorn/prefer-native-coercion-functions': 'off',
         'unicorn/prefer-negative-index': 'off',
-        'unicorn/prefer-switch': 'off',
     },
     reportUnusedDisableDirectives: true,
     globals: {

scripts/nightly-version.js

@@ -59,7 +59,7 @@ const getNightlyVersion = async function () {
         actions.setOutput('shouldPublish', false);
 
         console.log('No new commits since last publish. Exiting.');
-        process.exit(0);
+        process.exit(0); // eslint-disable-line unicorn/no-process-exit
 
         return;
     }

src/definitions/behaviors/api.js

@@ -461,7 +461,6 @@
                                             ? floatValue
                                             : (el.value === 'false' ? false : el.value)),
                                     nameKeys = el.name.match(settings.regExp.key) || [],
-                                    k,
                                     pushKey = el.name.replace(/\[]$/, '')
                                 ;
                                 if (!(pushKey in pushes)) {
@@ -476,7 +475,9 @@
                                     value = pushValues[pushKey];
                                 }
 
-                                while ((k = nameKeys.pop()) !== undefined) {
+                                while (nameKeys.length > 0) {
+                                    var k = nameKeys.pop();
+
                                     if (k == '' && !Array.isArray(value)) { // foo[]
                                         value = build([], pushes[pushKey]++, value);
                                     } else if (settings.regExp.fixed.test(k)) { // foo[n]
@@ -820,9 +821,7 @@
                         if (!isWindow(element)) {
                             if (module.is.input()) {
                                 data.value = $module.val();
-                            } else if (module.is.form()) {
-
-                            } else {
+                            } else if (!module.is.form()) {
                                 data.text = $module.text();
                             }
                         }

src/definitions/behaviors/form.js

@@ -136,7 +136,10 @@
                 },
 
                 attachEvents: function (selector, action) {
-                    action = action || 'submit';
+                    if (!action) {
+                        action = 'submit';
+                    }
+
                     $(selector).on('click' + eventNamespace, function (event) {
                         module[action]();
                         event.preventDefault();
@@ -283,7 +286,7 @@
 
                             $el.data(settings.metadata.isDirty, isDirty);
 
-                            formIsDirty |= isDirty;
+                            formIsDirty = formIsDirty || isDirty;
                         });
 
                         if (formIsDirty) {
@@ -618,16 +621,20 @@
                         module.verbose('Finding field with identifier', identifier);
                         identifier = module.escape.string(identifier);
                         var t;
-                        if ((t = $field.filter('#' + identifier)).length > 0) {
+                        t = $field.filter('#' + identifier);
+                        if (t.length > 0) {
                             return t;
                         }
-                        if ((t = $field.filter('[name="' + identifier + '"]')).length > 0) {
+                        t = $field.filter('[name="' + identifier + '"]');
+                        if (t.length > 0) {
                             return t;
                         }
-                        if ((t = $field.filter('[name="' + identifier + '[]"]')).length > 0) {
+                        t = $field.filter('[name="' + identifier + '[]"]');
+                        if (t.length > 0) {
                             return t;
                         }
-                        if ((t = $field.filter('[data-' + metadata.validate + '="' + identifier + '"]')).length > 0) {
+                        t = $field.filter('[data-' + metadata.validate + '="' + identifier + '"]');
+                        if (t.length > 0) {
                             return t;
                         }
                         module.error(error.noField.replace('{identifier}', identifier));
@@ -1866,14 +1873,24 @@
                     matchingValue,
                     matchingElement
                 ;
-                if ((matchingElement = $module.find('[data-validate="' + identifier + '"]')).length > 0) {
-                    matchingValue = matchingElement.val();
-                } else if ((matchingElement = $module.find('#' + identifier)).length > 0) {
+                matchingElement = $module.find('[data-validate="' + identifier + '"]');
+                if (matchingElement.length > 0) {
                     matchingValue = matchingElement.val();
-                } else if ((matchingElement = $module.find('[name="' + identifier + '"]')).length > 0) {
-                    matchingValue = matchingElement.val();
-                } else if ((matchingElement = $module.find('[name="' + identifier + '[]"]')).length > 0) {
-                    matchingValue = matchingElement;
+                } else {
+                    matchingElement = $module.find('#' + identifier);
+                    if (matchingElement.length > 0) {
+                        matchingValue = matchingElement.val();
+                    } else {
+                        matchingElement = $module.find('[name="' + identifier + '"]');
+                        if (matchingElement.length > 0) {
+                            matchingValue = matchingElement.val();
+                        } else {
+                            matchingElement = $module.find('[name="' + identifier + '[]"]');
+                            if (matchingElement.length > 0) {
+                                matchingValue = matchingElement;
+                            }
+                        }
+                    }
                 }
 
                 return (matchingValue !== undefined)
@@ -1888,14 +1905,24 @@
                     matchingValue,
                     matchingElement
                 ;
-                if ((matchingElement = $module.find('[data-validate="' + identifier + '"]')).length > 0) {
-                    matchingValue = matchingElement.val();
-                } else if ((matchingElement = $module.find('#' + identifier)).length > 0) {
-                    matchingValue = matchingElement.val();
-                } else if ((matchingElement = $module.find('[name="' + identifier + '"]')).length > 0) {
+                matchingElement = $module.find('[data-validate="' + identifier + '"]');
+                if (matchingElement.length > 0) {
                     matchingValue = matchingElement.val();
-                } else if ((matchingElement = $module.find('[name="' + identifier + '[]"]')).length > 0) {
-                    matchingValue = matchingElement;
+                } else {
+                    matchingElement = $module.find('#' + identifier);
+                    if (matchingElement.length > 0) {
+                        matchingValue = matchingElement.val();
+                    } else {
+                        matchingElement = $module.find('[name="' + identifier + '"]');
+                        if (matchingElement.length > 0) {
+                            matchingValue = matchingElement.val();
+                        } else {
+                            matchingElement = $module.find('[name="' + identifier + '[]"]');
+                            if (matchingElement.length > 0) {
+                                matchingValue = matchingElement;
+                            }
+                        }
+                    }
                 }
 
                 return (matchingValue !== undefined)
@@ -2005,7 +2032,7 @@
                 ;
                 while (length--) {
                     sum += producedValue[multiple][parseInt(cardNumber.charAt(length), 10)];
-                    multiple ^= 1;
+                    multiple ^= 1; // eslint-disable-line no-bitwise
                 }
 
                 return (sum % 10 === 0 && sum > 0);

src/definitions/behaviors/visibility.js

@@ -227,7 +227,7 @@
                 },
 
                 precache: function (images, callback) {
-                    if (!(images instanceof Array)) {
+                    if (!(Array.isArray(images))) {
                         images = [images];
                     }
                     var

src/definitions/modules/calendar.js

@@ -643,38 +643,51 @@
 
                         if (module.popup('is visible')) {
                             var mode = module.get.mode();
-                            if (keyCode === 37 || keyCode === 38 || keyCode === 39 || keyCode === 40) {
+                            switch (keyCode) {
                                 // arrow keys
-                                var bigIncrement = mode === 'day' ? 7 : mode === 'hour' ? 4 : mode === 'minute' ? timeGap.column : 3;
-                                var increment = keyCode === 37 ? -1 : keyCode === 38 ? -bigIncrement : keyCode == 39 ? 1 : bigIncrement;
-                                increment *= mode === 'minute' ? settings.minTimeGap : 1;
-                                var focusDate = module.get.focusDate() || module.get.date() || new Date();
-                                var year = focusDate.getFullYear() + (mode === 'year' ? increment : 0);
-                                var month = focusDate.getMonth() + (mode === 'month' ? increment : 0);
-                                var day = focusDate.getDate() + (mode === 'day' ? increment : 0);
-                                var hour = focusDate.getHours() + (mode === 'hour' ? increment : 0);
-                                var minute = focusDate.getMinutes() + (mode === 'minute' ? increment : 0);
-                                var newFocusDate = new Date(year, month, day, hour, minute);
-                                if (settings.type === 'time') {
-                                    newFocusDate = module.helper.mergeDateTime(focusDate, newFocusDate);
-                                }
-                                if (module.helper.isDateInRange(newFocusDate, mode)) {
-                                    module.set.focusDate(newFocusDate);
+                                case 37:
+                                case 38:
+                                case 39:
+                                case 40: {
+                                    var bigIncrement = mode === 'day' ? 7 : mode === 'hour' ? 4 : mode === 'minute' ? timeGap.column : 3;
+                                    var increment = keyCode === 37 ? -1 : keyCode === 38 ? -bigIncrement : keyCode == 39 ? 1 : bigIncrement;
+                                    increment *= mode === 'minute' ? settings.minTimeGap : 1;
+                                    var focusDate = module.get.focusDate() || module.get.date() || new Date();
+                                    var year = focusDate.getFullYear() + (mode === 'year' ? increment : 0);
+                                    var month = focusDate.getMonth() + (mode === 'month' ? increment : 0);
+                                    var day = focusDate.getDate() + (mode === 'day' ? increment : 0);
+                                    var hour = focusDate.getHours() + (mode === 'hour' ? increment : 0);
+                                    var minute = focusDate.getMinutes() + (mode === 'minute' ? increment : 0);
+                                    var newFocusDate = new Date(year, month, day, hour, minute);
+                                    if (settings.type === 'time') {
+                                        newFocusDate = module.helper.mergeDateTime(focusDate, newFocusDate);
+                                    }
+                                    if (module.helper.isDateInRange(newFocusDate, mode)) {
+                                        module.set.focusDate(newFocusDate);
+                                    }
+
+                                    break;
                                 }
-                            } else if (keyCode === 13) {
-                                // enter
-                                var date = module.get.focusDate();
-                                if (date && !settings.isDisabled(date, mode) && !module.helper.isDisabled(date, mode) && module.helper.isEnabled(date, mode)) {
-                                    if (settings.onSelect.call(element, date, module.get.mode()) !== false) {
-                                        module.selectDate(date);
+                                // enter key
+                                case 13: {
+                                    var date = module.get.focusDate();
+                                    if (date && !settings.isDisabled(date, mode) && !module.helper.isDisabled(date, mode) && module.helper.isEnabled(date, mode)) {
+                                        if (settings.onSelect.call(element, date, module.get.mode()) !== false) {
+                                            module.selectDate(date);
+                                        }
                                     }
+                                    // disable form submission:
+                                    event.preventDefault();
+                                    event.stopPropagation();
+
+                                    break;
                                 }
-                                // disable form submission:
-                                event.preventDefault();
-                                event.stopPropagation();
-                            } else if (keyCode === 27) {
-                                module.popup('hide');
-                                event.stopPropagation();
+                                // escape key
+                                case 27:
+                                    module.popup('hide');
+                                    event.stopPropagation();
+
+                                    break;
                             }
                         }
 
@@ -1320,7 +1333,10 @@
                         return date;
                     },
                     dateDiff: function (date1, date2, mode) {
-                        mode = mode || 'day';
+                        if (!mode) {
+                            mode = 'day';
+                        }
+
                         var isTimeOnly = settings.type === 'time';
                         var isYear = mode === 'year';
                         var isYearOrMonth = isYear || mode === 'month';
@@ -1643,8 +1659,7 @@
             today: function (settings) {
                 return settings.type === 'date' ? settings.text.today : settings.text.now;
             },
-            cell: function (cell, date, cellOptions) {
-            },
+            cell: function (cell, date, cellOptions) {},
         },
 
         parser: {
@@ -1684,7 +1699,7 @@
                     month = -1,
                     year = -1
                 ;
-                var isAm = undefined;
+                var isAm;
 
                 var isTimeOnly = settings.type === 'time';
                 var isDateOnly = settings.type.indexOf('time') < 0;
@@ -1897,28 +1912,22 @@
         },
 
         // callback when date changes
-        onChange: function (date, text, mode) {
-        },
+        onChange: function (date, text, mode) {},
 
         // callback before show animation, return false to prevent show
-        onShow: function () {
-        },
+        onShow: function () {},
 
         // callback after show animation
-        onVisible: function () {
-        },
+        onVisible: function () {},
 
         // callback before hide animation, return false to prevent hide
-        onHide: function () {
-        },
+        onHide: function () {},
 
         // callback after hide animation
-        onHidden: function () {
-        },
+        onHidden: function () {},
 
         // callback before item is selected, return false to prevent selection
-        onSelect: function (date, mode) {
-        },
+        onSelect: function (date, mode) {},
 
         // is the given date disabled?
         isDisabled: function (date, mode) {

src/definitions/modules/dropdown.js

@@ -967,17 +967,22 @@
                     if (queryLength === termLength) {
                         return (query === term);
                     }
-                    search: for (var characterIndex = 0, nextCharacterIndex = 0; characterIndex < queryLength; characterIndex++) {
+                    for (var characterIndex = 0, nextCharacterIndex = 0; characterIndex < queryLength; characterIndex++) {
                         var
+                            continueSearch = false,
                             queryCharacter = query.charCodeAt(characterIndex)
                         ;
                         while (nextCharacterIndex < termLength) {
                             if (term.charCodeAt(nextCharacterIndex++) === queryCharacter) {
-                                continue search;
+                                continueSearch = true;
+
+                                break;
                             }
                         }
 
-                        return false;
+                        if (!continueSearch) {
+                            return false;
+                        }
                     }
 
                     return true;
@@ -2122,9 +2127,7 @@
                                         return;
                                     }
                                     if (isMultiple) {
-                                        if ($.inArray(module.escape.htmlEntities(String(optionValue)), value.map(function (v) {
-                                            return String(v);
-                                        })) !== -1) {
+                                        if ($.inArray(module.escape.htmlEntities(String(optionValue)), value.map(String)) !== -1) {
                                             $selectedItem = ($selectedItem)
                                                 ? $selectedItem.add($choice)
                                                 : $choice;
@@ -3206,7 +3209,7 @@
                         }
                     },
                     diacritics: function (text) {
-                        return settings.ignoreDiacritics ? text.normalize('NFD').replace(/[\u0300-\u036f]/g, '') : text;
+                        return settings.ignoreDiacritics ? text.normalize('NFD').replace(/[\u0300-\u036F]/g, '') : text;
                     },
                 },