[API] Do not raise console error on all 2xx status codes on failure #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
y0hami
removed
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current API behavior raises an console error on failure, even when the status code was 2xx.
It only omits it when the status code is exactly 200
Testcase
Current: Only Status 200 is ignored
https://jsfiddle.net/q5osrg7k/2/
After: All Status 2xx are ignored
https://jsfiddle.net/q5osrg7k/3/
Screenshot
Current
After
Closes
Semantic-Org/Semantic-UI#4908