Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAIL if alternate caron is incorrect #3308

Closed
Tracked by #3319
RosaWagner opened this issue May 25, 2021 · 2 comments · Fixed by #4166
Closed
Tracked by #3319

FAIL if alternate caron is incorrect #3308

RosaWagner opened this issue May 25, 2021 · 2 comments · Fixed by #4166
Assignees
@yanone
Labels
GF's priority list List of high priority issues for google/fonts CI New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P3 Soon Severity 4
Milestone
0.9.0

Comments

@RosaWagner
Copy link
Contributor

RosaWagner commented May 25, 2021 •
edited
Loading

Lcaron, dcaron, lcaron, tcaron should NOT be composed with quoteright or quotesingle or comma or caron(comb). It should be composed with a distinctive glyph which doesn't look like an apostrophe: preferably caroncomb.alt (eventually caroncomb.alt.case for Lcaron).

sources
https://ilovetypography.com/2009/01/24/on-diacritics/
http://diacritics.typo.cz/index.php?id=5
https://www.typotheque.com/articles/lcaron

You can find a case of Lcaron using a component made with comma here:
https://github.com/ThomasJockin/QuicksandFamily/tree/3d1e9808cb8594744d031e733a982d985bd4f126

In this tricky case, caroncomb.alt is a copy of the contours of quotesingle. So name and usage is correct but not the shape:
https://github.com/Etcetera-Type-Co/Tourney
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label May 25, 2021
@felipesanches felipesanches self-assigned this May 25, 2021
@felipesanches
Copy link
Collaborator

felipesanches commented May 26, 2021 •
edited
Loading

You can find a case of Lcaron using a component made with comma here:
https://github.com/ThomasJockin/QuicksandFamily/tree/3d1e9808cb8594744d031e733a982d985bd4f126

I am trying to implement this check.
I followed the URL you posted but I think it is a bit ambiguous because I don't know if you are talking about the static TTF files in that specific commit or talking about the VF TTF, or even the source files in that repo.

Inspecting the static TTF of the Regular I see an Lcaron which does not use components, which makes me believe that's not what you were referring to. Nevertheless, how should we deal with cases like this?

Screenshot from 2021-05-26 01-01-33

@RosaWagner
Copy link
Contributor Author

Ah in this case, they decomposed L in Lcaron in the sources, so the entire glyph is decomposed during export. tcaron will have the issue we are looking for. Although for this build they didn't use the flatten component flag, and the said component will be caronalt (wrong name but not that important imo), which is made with a component of comma.

Deeply sorry for this confusion.

Now, if we do have the case of decomposed outlines… I don't know. The most occurring case remains components in variable fonts and static ttf, and it is already helpful if we can check for that because it is happening often.

@felipesanches felipesanches added this to the 0.7.x milestone May 26, 2021
@felipesanches felipesanches modified the milestones: 0.7.x, 0.8.x series Jul 14, 2021
@vv-monsalve vv-monsalve mentioned this issue Jun 30, 2022
Merged
4 tasks
@RosaWagner RosaWagner changed the title check if alternate caron is correct WARN if alternate caron is incorrect Nov 23, 2022
@RosaWagner RosaWagner mentioned this issue Nov 23, 2022
Open
10 tasks
@RosaWagner RosaWagner added the GF's priority list List of high priority issues for google/fonts CI label Mar 16, 2023
@RosaWagner RosaWagner changed the title WARN if alternate caron is incorrect FAIL if alternate caron is incorrect Mar 16, 2023
@felipesanches felipesanches modified the milestones: 0.8.x series, 0.8.12 Mar 17, 2023
@RosaWagner RosaWagner assigned yanone and unassigned felipesanches May 19, 2023
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.14 Jun 2, 2023
@yanone yanone mentioned this issue Jun 7, 2023
Merged
3 tasks
@yanone yanone linked a pull request Jun 7, 2023 that will close this issue
New check: alt caron #4166
Merged
3 tasks
felipesanches pushed a commit that referenced this issue Jun 18, 2023
@yanone @felipesanches
New check: com.google.fonts/check/alt_caron
35d068a 
Check that alternate caron is used in the four affected Latin glyphs.

Added to the Universal Profile.
(issue #3308)
felipesanches added a commit that referenced this issue Jun 18, 2023
@felipesanches
Add comments with glyphname on the lists of codepoints
167ccb4 
And a few minor tweaks to code and text-strings formatting.
(issue #3308)
felipesanches added a commit that referenced this issue Jun 18, 2023
@felipesanches
Add comments with glyphname on the lists of codepoints
3a53f5d 
And a few minor tweaks to code and text-strings formatting.
(issue #3308)
felipesanches pushed a commit to felipesanches/fontbakery that referenced this issue Jul 21, 2023
@yanone @felipesanches
New check: com.google.fonts/check/alt_caron
5175bd9 
Check that alternate caron is used in the four affected Latin glyphs.

Added to the Universal Profile.
(issue fonttools#3308)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 21, 2023
@felipesanches
Add comments with glyphname on the lists of codepoints
d9bc200 
And a few minor tweaks to code and text-strings formatting.
(issue fonttools#3308)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 21, 2023
@felipesanches
Add comments with glyphname on the lists of codepoints
5963b30 
And a few minor tweaks to code and text-strings formatting.
(issue fonttools#3308)
felipesanches added a commit that referenced this issue Jul 21, 2023
@felipesanches
Add comments with glyphname on the lists of codepoints
76bf676 
And a few minor tweaks to code and text-strings formatting.
(issue #3308)
felipesanches pushed a commit that referenced this issue Jul 21, 2023
@yanone @felipesanches
New check: com.google.fonts/check/alt_caron
b734f96 
Check that alternate caron is used in the four affected Latin glyphs.

Added to the Universal Profile.
(issue #3308)
felipesanches added a commit that referenced this issue Jul 21, 2023
@felipesanches
Add comments with glyphname on the lists of codepoints
5d46673 
And a few minor tweaks to code and text-strings formatting.
(issue #3308)
felipesanches pushed a commit that referenced this issue Feb 1, 2024
@yanone @felipesanches
Purge known-wrong endings from glyph names to check
f340a51 
com.google.fonts/check/alt_caron
On the Universal profile

Expanded to catch casing variants like "caroncomb.case" as well. The check previously didn't catch L+caroncomb.case, because the it relies on Unicodes to identify wrong accents. Now, we're purging known-wrong endings (e.g. .case) before resolving the Unicode, so that caroncomb.case can be found.

(issue #3308 / PR #4469)
felipesanches pushed a commit that referenced this issue Feb 1, 2024
@yanone @felipesanches
Purge known-wrong endings from glyph names to check
bcfc6f6 
com.google.fonts/check/alt_caron
On the Universal profile

Expanded to catch casing variants like "caroncomb.case" as well. The check previously didn't catch L+caroncomb.case, because the it relies on Unicodes to identify wrong accents. Now, we're purging known-wrong endings (e.g. .case) before resolving the Unicode, so that caroncomb.case can be found.

(issue #3308 / PR #4469)
@yanone yanone mentioned this issue Apr 19, 2024
Open
@yanone yanone mentioned this issue May 8, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanone yanone

Labels
GF's priority list List of high priority issues for google/fonts CI New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P3 Soon Severity 4
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

New check: alt caron fonttools/fontbakery
4 participants
@yanone @felipesanches @RosaWagner @vv-monsalve