-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for GF release #11
Comments
FontBakery reportfontbakery version: 0.12.5 Check results[13] Maname-Regular.ttf💥 ERROR Check the direction of the outermost contour in each glyph
[code: failed-check] 🔥 FAIL Check glyphs do not have duplicate components which have the same x,y coordinates.
🔥 FAIL Check accent of Lcaron, dcaron, lcaron, tcaron
Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, one of the comma-lookalikes is a FAIL [code: bad-mark]
Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, one of the comma-lookalikes is a FAIL [code: bad-mark]
Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, one of the comma-lookalikes is a FAIL [code: bad-mark]
Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, one of the comma-lookalikes is a FAIL [code: bad-mark]🔥 FAIL Space and non-breaking space have the same width?
🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Check license file has good copyright string.
"copyright (c) 2015-2017, maname fonts project authors." which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]🔥 FAIL A font repository should not include ZIP files
🔥 FAIL Copyright notices match canonical pattern in fonts
"Copyright 2019 The Familyname Project Authors (git url)" But instead we have got: "Copyright 2015—2023 The Maname Project Authors <See at https://github.com/mooniak/maname-font/>" [code: bad-notice-format]🔥 FAIL Check font names are correct
🔥 FAIL Checking OS/2 fsType does not impose restrictions.
No such DRM restrictions can be enabled on the Google Fonts collection, so the fsType field must be set to zero (Installable Embedding) instead. [code: drm]🔥 FAIL Check Google Fonts glyph coverage.
[code: missing-codepoints] 🔥 FAIL Are there non-ASCII characters in ASCII-only NAME table entries?
🔥 FAIL Check font follows the Google Fonts vertical metric schema
[1] Family checks🔥 FAIL OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts.
Summary
Note: The following loglevels were omitted in this report:
|
Please address all of the above Fontbakery FAILs. A few comments: Check accent of Lcaron, dcaron, lcaron, tcaron Shapes languages in all GF glyphsets Additionally and related (the check is currently disabled in Fontbakery), please ensure that all legacy accents (non- In fact, I tried to fix issues myself quickly and was going to send you a PR back, but changing the spacing of the marks changed the mark positions in all accented letters, and that was too much for me to deal with. Using automatic composition with anchors would have solved that, as the anchor positions are then relevant to the composition and not the mark's sidebearings, so the composed glyphs would have not changed at all when adjusting the sidebearings. A font repository should not include ZIP files Generally, please consider using Fontbakery on your end. You can update it to the latest version with |
@pathumego Please merge this PR (just spell-checking on the description) and then create a release so we can publish it. We need either a release or the font files to be available in the repo directly. I have 6 more work days until end of June before my summer break. Would be great if we could finish this. We're almost there. The fonts are looking great. |
README.md
FONTLOG.md
OFL.tt
FONTLOG.md
The text was updated successfully, but these errors were encountered: