Refactored com.google.fonts/check/102 into two checks #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com.google.fonts/check/102 will not run on upstream font repos since it needs a METADATA.pb file. This check will now only check that METADATA.pb files have the correct copyright string. com.google.fonts/check/font_copyright will ensure that a font's copyright strings are correct.
m4rc1e
commented
Mar 8, 2019
| import re | ||
| from fontbakery.utils import get_name_entry_strings | ||
| string = font_metadata.copyright | ||
| does_match = re.search(r'Copyright [0-9]{4} The .* Project Authors \([^\@]*\)', |
There was a problem hiding this comment.
@felipesanches perhaps we could define our copyright pattern in the constants module?
There was a problem hiding this comment.
I tend to only split out things to the constants module if they are used by more than a single check. Otherwise I prefer to keep the code explicit, so that it is easier to grasp at one quick glance without opening multiple source files.
|
since we're changing a lot the behaviour of com_google_fonts_check_102 I would suggest we deprecate it and give a new check id to both halves of it, instead of to only one of them. |
|
that means, let's take all opportunities to gradually change from numerical check-IDs to names using mnemonic keywords. |
felipesanches
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Mar 21, 2019
…hecks com.google.fonts/check/metadata/valid_copyright will not run on upstream font repos since it needs a METADATA.pb file. This check will now only check that METADATA.pb files have the correct copyright string. New check com.google.fonts/check/font_copyright will ensure that a font's copyright strings are correct. (follow-up to PR fonttools#2383)
felipesanches
pushed a commit
that referenced
this pull request
Mar 21, 2019
…hecks com.google.fonts/check/metadata/valid_copyright will not run on upstream font repos since it needs a METADATA.pb file. This check will now only check that METADATA.pb files have the correct copyright string. New check com.google.fonts/check/font_copyright will ensure that a font's copyright strings are correct. (follow-up to PR #2383)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.google.fonts/check/102 will not run on upstream font repos since it needs a METADATA.pb file. This check will now only check that METADATA.pb files have the correct copyright string.
com.google.fonts/check/font_copyright will ensure that a font's copyright strings are correct.
Fixes #2210