Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support Python 3.7, run tests on Python 3.11 #247

Merged
merged 7 commits into from
Dec 2, 2023
Merged

Conversation

anthrotype
Copy link
Member

FontTools has dropped support for 3.7, thus we follow suit

fonttools/fonttools#2879
fonttools/fonttools#2878

@anthrotype
Copy link
Member Author

anthrotype commented Nov 7, 2022

ah yes, no windows 3.11 wheels yet for lxml ... :-/

@khaledhosny
Copy link
Collaborator

I fixed some mypy errors, the remaining ones are all Greek to me.

I don’t understand what these are:
src/ufoLib2/serde/__init__.py:91: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[str, bytes], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[_T], Union[str, bytes], NamedArg(Callable[..., _T]), KwArg(Any)], _T]"  [arg-type]
src/ufoLib2/serde/__init__.py:91: note: This is likely because "_loads" has named arguments: "cls". Consider marking them positional-only
src/ufoLib2/serde/__init__.py:91: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[str, bytes], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[Any], Union[str, bytes], NamedArg(Callable[..., Any]), KwArg(Any)], Any]"  [arg-type]
src/ufoLib2/serde/__init__.py:96: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[AnyStr]], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[_T], Union[str, bytes, PathLike[str], PathLike[bytes], IO[AnyStr]], NamedArg(Callable[..., _T]), KwArg(Any)], _T]"  [arg-type]
src/ufoLib2/serde/__init__.py:96: note: This is likely because "_load" has named arguments: "cls". Consider marking them positional-only
src/ufoLib2/serde/__init__.py:96: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[AnyStr]], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[Any], Union[str, bytes, PathLike[str], PathLike[bytes], IO[AnyStr]], NamedArg(Callable[..., Any]), KwArg(Any)], Any]"  [arg-type]
@khaledhosny
Copy link
Collaborator

Ignored the remaining two.

@khaledhosny khaledhosny merged commit dada466 into main Dec 2, 2023
7 checks passed
@khaledhosny khaledhosny deleted the drop-py37 branch December 2, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants