Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support Python 3.7, run tests on Python 3.11 #247

Merged
merged 7 commits into from
Dec 2, 2023
Merged

Drop support Python 3.7, run tests on Python 3.11 #247

merged 7 commits into from
Dec 2, 2023

Commits on Dec 2, 2023

  1. Drop support Python 3.7, run tests on Python 3.11 

    FontTools has dropped support for 3.7, thus we follow suit

fonttools/fonttools#2879
fonttools/fonttools#2878
    @anthrotype @khaledhosny
    anthrotype authored and khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    420444a View commit details
    Browse the repository at this point in the history

  2. import generic abstract collections from typing module, instead of co… 

    …llections.abc

Fixes TypeError on Python 3.8
https://github.com/fonttools/ufoLib2/actions/runs/3404749253/jobs/5662213808
    @anthrotype @khaledhosny
    anthrotype authored and khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    2f24905 View commit details
    Browse the repository at this point in the history

  3. remove typing_extensions from install_requires 

    No longer needed since we target >= 3.8 now
    @anthrotype @khaledhosny
    anthrotype authored and khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    36684d4 View commit details
    Browse the repository at this point in the history

  4. Update requirements

    @khaledhosny
    khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    488a5b8 View commit details
    Browse the repository at this point in the history

  5. Black

    @khaledhosny
    khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    87ce061 View commit details
    Browse the repository at this point in the history

  6. Fix some mypy errors

    @khaledhosny
    khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    01a5ced View commit details
    Browse the repository at this point in the history

  7. Ignore remaining mypy errors 

    I don’t understand what these are:
src/ufoLib2/serde/__init__.py:91: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[str, bytes], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[_T], Union[str, bytes], NamedArg(Callable[..., _T]), KwArg(Any)], _T]"  [arg-type]
src/ufoLib2/serde/__init__.py:91: note: This is likely because "_loads" has named arguments: "cls". Consider marking them positional-only
src/ufoLib2/serde/__init__.py:91: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[str, bytes], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[Any], Union[str, bytes], NamedArg(Callable[..., Any]), KwArg(Any)], Any]"  [arg-type]
src/ufoLib2/serde/__init__.py:96: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[AnyStr]], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[_T], Union[str, bytes, PathLike[str], PathLike[bytes], IO[AnyStr]], NamedArg(Callable[..., _T]), KwArg(Any)], _T]"  [arg-type]
src/ufoLib2/serde/__init__.py:96: note: This is likely because "_load" has named arguments: "cls". Consider marking them positional-only
src/ufoLib2/serde/__init__.py:96: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[AnyStr]], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[Any], Union[str, bytes, PathLike[str], PathLike[bytes], IO[AnyStr]], NamedArg(Callable[..., Any]), KwArg(Any)], Any]"  [arg-type]
    @khaledhosny
    khaledhosny committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    c06fc18 View commit details
    Browse the repository at this point in the history