Updating release branch with the 2.0 dev #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…holders and there are no unit tests. So that will be the next step.
IOC to abstract rule engines from rule manager code
…tests, replace placeholder labels, and such.
…nd why it was doing that, though.
D/w 7434792 b
…d tsyringe. Lots of changes here, but all just refactoring and cleanup. Added missing types, introduced more interfaces, made async initialization a bit more consistent. The ESLint engine is there, but returning no rules/categories/rulesets. Biggest change was to restructure the catalog json, both the new Catalog.json and the existing PmdCatalog.json. Uses arrays now instead of an object map.
IOC part 2
…onal test project fixtures.
…er initial code review
…packaged-sanity in config.yml
…ter support for tsconfig.
@W-7742718@ Filter PMD results before processing violations
…m-takes-precedence @W-776022@ Give precedence to --tsconfig flag over cwd
Handle situations where the json catalogs are out of sync with the file system because the referenced file no longer exists. Skip the file and show the user a warning.
Removed unnecessary temp variable.
Changed error message Restore unit tests that shouldn't use constants Use .entries() to iterate over map contents
@W-7792085@ Filter out invalid catalog files
Adds an entry for an out of memory error that can occur when scanning large projects.
…e language in the comments.
D/w 7791882 b
@W-7802169@ Add eslint out of memory troubleshooter
added jasmine, jest, jquery, and mocha to reduce scanning noise.
@W-7805991@ Add more defaults to DEFAULT_ENV_VARS
Update to add Google Tag Manager for analytics
Incrementing version to 2.0.0.
Fixing error in packaged-sanity command.
jbartolotta-sfdc
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.