Cristi/push fix (#5441)

* fix: diagnostics for push * test: fixed tests
forcedotcom · Feb 20, 2024 · 367b702 · 367b702
1 parent ba20ccf
commit 367b702
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/salesforcedx-utils-vscode/src/cli/parsers/projectDeployStartResultParser.ts b/packages/salesforcedx-utils-vscode/src/cli/parsers/projectDeployStartResultParser.ts
@@ -53,7 +53,9 @@ export class ProjectDeployStartResultParser {
         message: this.response.message ?? 'Push failed. ',
         name: this.response.name ?? 'DeployFailed',
         status: this.response.status,
-        files: this.response.data ?? this.response.result.files
+        files: (this.response.data ?? this.response.result.files).filter(
+          (file: { state: string }) => file.state === 'Failed'
+        )
       } as ProjectDeployStartErrorResponse;
     }
   }

diff --git a/packages/salesforcedx-utils-vscode/src/cli/parsers/projectRetrieveStartResultParser.ts b/packages/salesforcedx-utils-vscode/src/cli/parsers/projectRetrieveStartResultParser.ts
@@ -53,7 +53,9 @@ export class ProjectRetrieveStartResultParser {
         message: this.response.message ?? 'Pull failed. ',
         name: this.response.name ?? 'RetrieveFailed',
         status: this.response.status,
-        files: this.response.data ?? this.response.result.files
+        files: (this.response.data ?? this.response.result.files).filter(
+          (file: { state: string }) => file.state === 'Failed'
+        )
       } as ProjectRetrieveStartErrorResponse;
     }
   }

diff --git a/...rcedx-vscode-core/test/vscode-integration/commands/projectDeployStartResultParser.test.ts b/...rcedx-vscode-core/test/vscode-integration/commands/projectDeployStartResultParser.test.ts
@@ -85,7 +85,7 @@ describe('Correctly output deploy results', () => {
         { key: 'type', label: nls.localize('table_header_type') },
         { key: 'filePath', label: nls.localize('table_header_project_path') }
       ],
-      nls.localize('table_title_deployed_source')
+      nls.localize('table_title_pushed_source')
     );
     expect(output).to.be.equal(`${successTable}\n`);
   });
@@ -105,7 +105,7 @@ describe('Correctly output deploy results', () => {
         { key: 'type', label: nls.localize('table_header_type') },
         { key: 'filePath', label: nls.localize('table_header_project_path') }
       ],
-      nls.localize('table_title_deployed_source')
+      nls.localize('table_title_pushed_source')
     );
     const expectedOutput = `${successTable}\n${nls.localize(
       'table_no_results_found'