Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cristi/push fix #5441

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Cristi/push fix #5441

merged 2 commits into from
Feb 20, 2024

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Fixes error when trying to generate the output table from all the files involved in a push and some of the files didn't have errors. Now the files considered for the output table are only those that failed

Functionality Before

  • no error messages shown upon errors

Functionality After

  • Correct displaying of error messages

[skip-validate-pr]

@CristiCanizales CristiCanizales requested a review from a team as a code owner February 20, 2024 14:17
daphne-sfdc
daphne-sfdc approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

  • SFDX: Push Source to Default Org - error case shows error messages in Output tab ✅
  • SFDX: Push Source to Default Org and Ignore Conflicts - error case shows error messages in Output tab ✅

@CristiCanizales CristiCanizales merged commit 367b702 into develop Feb 20, 2024
12 checks passed
@CristiCanizales CristiCanizales deleted the cristi/push-fix branch February 20, 2024 15:00
@CristiCanizales CristiCanizales mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphne-sfdc daphne-sfdc daphne-sfdc approved these changes

@gbockus-sf gbockus-sf Awaiting requested review from gbockus-sf gbockus-sf is a code owner automatically assigned from forcedotcom/ide-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CristiCanizales @daphne-sfdc