fix: remove copying of apex.db to workspace on LS startup #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-13190794@
…into phale/perf-poc
…into phale/apex-db-overlay # Conflicts: # .vscode/launch.json # packages/salesforcedx-vscode-apex/out/apex-jorje-lsp.jar
@W-13875940@
…into phale/apex-db-overlay
…into phale/apex-db-overlay
…into phale/apex-db-overlay
…into phale/apex-db-overlay # Conflicts: # packages/salesforcedx-vscode-apex/src/languageServer.ts
packages/salesforcedx-vscode-apex/test/vscode-integration/languageServer.test.ts
Outdated
Show resolved
Hide resolved
supert3d
reviewed
Sep 15, 2023
.github/workflows/e2ePerf.yml
Outdated
| - name: Setup YourKit | ||
| run: echo "YOURKIT_PROFILER_AGENT=${{ env.RUNNER_OS }}-${{ env.RUNNER_ARCH}}=sampling,async_sampling_cpu,app_name=apex_lsp,alloc_object_counting" >> $GITHUB_ENV | ||
| - name: Setup YourKit Agent | ||
| run: echo "YOURKIT_PROFILER_AGENT=${{ env.RUNNER_OS }}-${{ env.RUNNER_ARCH}}=sampling,async_sampling_cpu,app_name=apex_lsp,alloc_object_counting,onexit=memory,onexit=memory,onexit=snapshot,onexit=hprof,dir=./snapshots" >> $GITHUB_ENV |
There was a problem hiding this comment.
onexit=memory twice? Not sure if this was deliberate?
There was a problem hiding this comment.
@supert3d Good catch. I'll log a bug to have the duplicate removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the initialization of apex.db each time the Apex LS is started
Language server will be responsible for "installing"/"upgrading" apex.db
fix: disable file watcher for apex std classes dir
What issues does this PR fix or reference?
@W-13593866@
@W-13739509@
QA Notes:
.sfdx/toolsdir and the file should not be overlayed by extension.sfdx/toolsdir and the file should be created by the language server