-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove copying of apex.db to workspace on LS startup #4956
Merged
Merged
Changes from 3 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
cee7a05
chore: enable yourkit testing for e2ePerf
peternhale e2c76cf
chore: fix workflow name
peternhale f4ec8eb
chore: capture yourkit snashot
peternhale 8056167
chore: apply review suggestions
peternhale 1b544d5
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 506a8ac
Merge branch 'develop' into phale/perf-poc
peternhale 2c36f69
chore: change strategy for yourkit agent definition
peternhale fa631a9
chore: testing creation of env manipulation
peternhale 69e2032
chore: more env handling
peternhale 22dde81
chore: use format
peternhale c9976b2
chore: getting closer
peternhale 566c433
chore: fix env var names
peternhale 1a94b09
chore: try again
peternhale 3ec4944
chore: make it work
peternhale 98d89fe
chore: remove trailing data on env var echo
peternhale dae392b
chore: debug
peternhale 564cfd9
chore: mor debugging
peternhale 16f67d0
chore: fix env case
peternhale e9fd664
chore: turn on tests
peternhale 26d6ca5
chore: enable profiling outside of debug
peternhale 2345af7
chore: run without tests
peternhale 35a263e
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 340af97
chore: add env vars for project and test to run
peternhale 6bb8dbb
chore: wip
peternhale 99ab844
chore: wip
peternhale 08d3233
chore: first iteration of apex ls perf changes
peternhale 6c5a37e
chore: fix lint
peternhale c2c801b
chore: add env vars to launch
peternhale 4c5cb42
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale f7b8493
chore: remove code that copies apex.db
peternhale 4a3eda1
chore: remove reference apex.db
peternhale ff3c879
Merge branch 'develop' into phale/apex-db-overlay
peternhale 0ca02e0
fix: disable file watcher for apex std classes dir
peternhale 5e26321
fix: correct env ref syntax
peternhale 60188a0
fix: reduce file system watchers from 4 to 2
peternhale 5c033d2
chore: check in signed version of the jar
peternhale 5edf61f
Merge branch 'develop' into phale/apex-db-overlay
peternhale 799187b
chore: unneeded at this time
peternhale e2bcd68
chore: working lsp jar
peternhale 4a6986b
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 681a311
chore: fix lint error
peternhale 6b0eca6
chore: add ability to ser apex ls log level
peternhale 5ea20ab
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 3fae70a
chore: add signed jar to pr
peternhale 2d300cd
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 3232e8b
Merge branch 'develop' into phale/apex-db-overlay
CristiCanizales bcebceb
chore: update jar for testing on windows
peternhale 81300ea
chore: testing
peternhale 8b1b205
chore: more logging
peternhale 76ec925
chore: more logging
peternhale 126c3c2
chore: add more logging
peternhale 1448270
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale c872036
chore: update package lock
peternhale 256a311
chore: update jar
peternhale 40ce9d2
chore: add more logging to prelude
peternhale f44218b
chore: make sure paths.get does not have a uri string
peternhale c3727a2
chore: closer
peternhale 24cb13f
chore: one step forward
peternhale 18e252a
fix: update lsp jar that runs properly on windows
peternhale dc2c373
Merge branch 'develop' into phale/apex-db-overlay
CristiCanizales d343dd6
chore: update ls jar
peternhale 5db3d98
chore: fix URI bug in LS
peternhale fbe6c07
chore: one more LS fix
peternhale b003d0d
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 9629b71
chore: refresh system.db
peternhale b5b1837
chore: goodness hopefully
peternhale 066bb1c
chore: new jar with larger LRU cache
peternhale 08925cd
chore: more debugging
peternhale c09b188
chore: update ls jar
peternhale 7f82cb2
chore: make sure standard library classes do not compile twice
peternhale 55eaf0d
chore: allow remote apex LS debugging
peternhale 360b861
fix: apex LS duplicate method exception windows
peternhale ab361e5
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 68e6a85
chore: update LS to df
peternhale 9ee5936
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 79ff971
Merge branch 'develop' of github.com:forcedotcom/salesforcedx-vscode …
peternhale 664391b
chore: fix merge error
peternhale 10fa058
chore: give test better name
peternhale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
name: End to End Tests (Performance) | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
automationBranch: | ||
description: 'Set the branch to use for automation tests' | ||
required: false | ||
default: 'phale/perf-poc' | ||
type: string | ||
|
||
# all possible combinations of OS and architecture supported by yourkit | ||
env: | ||
Linux-ARM: ./yourkit-distro/linux-arm-32/libyjpagent.so | ||
Windows-X86: ./yourkit-distro/windows-x86-32/yjpagent.dll | ||
Linux-X86: ./yourkit-distro/linux-x86-32/libyjpagent.so | ||
Windows-X64: ./yourkit-distro/windows-x86-64/yjpagent.dll | ||
Linux-ARM64: ./yourkit-distro/linux-arm-64/libyjpagent.so | ||
macOs-X64: ./yourkit-distro/mac/libyjpagent.dylib | ||
Windows-ARM64: ./yourkit-distro/windows-arm-64/yjpagent.dll | ||
Linux-X64: ./yourkit-distro/linux-x86-64/libyjpagent.so | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
matrix: | ||
os: [macos-latest] | ||
nodeVersion: | ||
- 16.15.1 | ||
vscodeVersion: | ||
- stable | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
with: | ||
path: ./salesforcedx-vscode | ||
ref: ${{ github.event.ref }} | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.nodeVersion }} | ||
cache: npm | ||
cache-dependency-path: | | ||
salesforcedx-vscode/package-lock.json | ||
salesforcedx-vscode-automation-tests/package-lock.json | ||
- name: Clone automation tests | ||
uses: actions/checkout@v3 | ||
with: | ||
repository: forcedotcom/salesforcedx-vscode-automation-tests | ||
path: salesforcedx-vscode-automation-tests | ||
ref: ${{ inputs.automationBranch }} | ||
- name: Install Extension Dependencies | ||
run: | | ||
npm install | ||
working-directory: salesforcedx-vscode | ||
- name: Install Test Dependencies | ||
run: | | ||
npm install | ||
working-directory: salesforcedx-vscode-automation-tests | ||
- name: Install the SFDX CLI | ||
run: npm install -g sfdx-cli | ||
- name: Verify CLI | ||
shell: bash | ||
run: | | ||
set -e | ||
sfdx version | ||
SFDX_CLI_VERSION=$(sfdx version) | ||
if [[ ((`echo $SFDX_CLI_VERSION | grep -c "sfdx-cli/"` > 0))]] | ||
then | ||
echo "sfdx-cli installed -" $SFDX_CLI_VERSION | ||
else | ||
echo "The sfdx-cli installation could not be verified" | ||
exit 1 | ||
fi | ||
- name: Setup YourKit Agent | ||
run: echo "YOURKIT_PROFILER_AGENT=${{ env.RUNNER_OS }}-${{ env.RUNNER_ARCH}}=sampling,async_sampling_cpu,app_name=apex_lsp,alloc_object_counting,onexit=memory,onexit=memory,onexit=snapshot,onexit=hprof,dir=./snapshots" >> $GITHUB_ENV | ||
- name: Create Yourkit Snapshot directory | ||
run: mkdir snapshots | ||
- name: Verify YourKit | ||
run: env | ||
# - name: Run headless test | ||
# uses: coactions/setup-xvfb@b6b4fcfb9f5a895edadc3bc76318fae0ac17c8b3 | ||
# with: | ||
# run: npm run automation-tests | ||
# working-directory: salesforcedx-vscode-automation-tests | ||
# env: | ||
# VSCODE_VERSION: ${{ matrix.vscodeVersion }} | ||
- uses: actions/upload-artifact@v3 | ||
with: | ||
name: yourkit-snapshot | ||
path: snapshots |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
The following files can be redistributed under the license below: | ||
|
||
yjpagent.dll | ||
libyjpagent.so | ||
libyjpagent.dylib | ||
yjp-controller-api-redist.jar | ||
yjp-probe-api-redist.jar | ||
|
||
------------------------------------------------------------------- | ||
|
||
Copyright (c) 2003-2022, YourKit | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without | ||
modification, are permitted provided that the following conditions are met: | ||
|
||
* Redistributions of source code must retain the above copyright | ||
notice, this list of conditions and the following disclaimer. | ||
|
||
* Redistributions in binary form must reproduce the above copyright | ||
notice, this list of conditions and the following disclaimer in the | ||
documentation and/or other materials provided with the distribution. | ||
|
||
* Neither the name of YourKit nor the | ||
names of its contributors may be used to endorse or promote products | ||
derived from this software without specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY YOURKIT "AS IS" AND ANY | ||
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL YOURKIT BE LIABLE FOR ANY | ||
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND | ||
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onexit=memory
twice? Not sure if this was deliberate?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supert3d Good catch. I'll log a bug to have the duplicate removed.