fix: filter allowedProperties on getConfigInfo

forcedotcom · Feb 11, 2021 · cbb91e1 · cbb91e1
1 parent 49618db
commit cbb91e1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/config/configAggregator.ts b/src/config/configAggregator.ts
@@ -245,6 +245,7 @@ export class ConfigAggregator extends AsyncOptionalCreatable<JsonMap> {
    */
   public getConfigInfo(): ConfigInfo[] {
     const infos = Object.keys(this.getConfig())
+      .filter((key) => this.getAllowedProperties().some((element) => key === element.key))
       .map((key) => this.getInfo(key))
       .filter((info): info is ConfigInfo => !!info);
     return sortBy(infos, 'key');

diff --git a/test/unit/config/configAggregatorTest.ts b/test/unit/config/configAggregatorTest.ts
@@ -160,7 +160,7 @@ describe('ConfigAggregator', () => {
       expect(aggregator.getLocation(Config.DEFAULT_USERNAME)).to.equal('Environment');
     });
 
-    it('configInfo', async () => {
+    it('configInfo with env', async () => {
       process.env.SFDX_DEFAULTUSERNAME = 'test';
       $$.SANDBOX.stub(fs, 'readJson').returns(Promise.resolve({}));
 
@@ -170,5 +170,15 @@ describe('ConfigAggregator', () => {
       expect(info.value).to.equal('test');
       expect(info.location).to.equal('Environment');
     });
+
+    it('configInfo ignores invalid entries', async () => {
+      $$.SANDBOX.stub(fs, 'readJsonMap').returns(Promise.resolve({ invalid: 'entry', apiVersion: 49.0 }));
+
+      const aggregator: ConfigAggregator = await ConfigAggregator.create();
+      const info = aggregator.getConfigInfo()[0];
+      expect(info.key).to.equal('apiVersion');
+      expect(info.value).to.equal(49.0);
+      expect(info.location).to.equal('Local');
+    });
   });
 });