Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no throw on unknown config value #372

Merged
merged 2 commits into from
Feb 11, 2021
Merged

fix: no throw on unknown config value #372

merged 2 commits into from
Feb 11, 2021

Conversation

amphro
Copy link
Collaborator

@amphro amphro commented Feb 11, 2021

Right now, old versions of the core library will throw if there is an unknown key in the config file. If a new key is added in future versions of core, the old version doesn't know about it and will throw. THis prevents this from happening in the future.

@W-8880355@

@codecov-io
Copy link

Codecov Report

Merging #372 (49618db) into main (934e34c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          38       38           
  Lines        3189     3189           
  Branches      555      556    +1     
=======================================
  Hits         2633     2633           
  Misses        341      341           
  Partials      215      215           
Impacted Files Coverage Δ
src/config/config.ts 73.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b214da3...49618db. Read the comment docs.

@peternhale peternhale merged commit 45e4613 into main Feb 11, 2021
@peternhale peternhale deleted the td/nothrowonconfig branch February 11, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants