-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Bootstrap 4 #577
Conversation
Adding in support for Bootstrap 4
Adding support for Bootstrap 4 and using inline checkboxes
fixed the namespace
Wow! Thanks so much @bdewong! This looks fantastic. Would you be willing to copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will need renamed from TwitterBootstrap4.php
to TwitterBootstrap4Test.php
and the tests will need updated to pass.
Sorry, I created them online to get started. I've gone ahead and updated them and they are now passing. |
* 'master' of github.com:formers/former: (47 commits) Support Laravel 7 Fix errors when using rules in validation array Add tests Fix errors when using rules in validation array Laravel 6 support (formers#591) Adds correct checkbox input class when is a checkbox (or radio) (formers#590) Encode checkbox value to prevent XSS attack (formers#584) Fix the Bootstrap 4 help blocks Fix tabs vs spaces :) Fix Bootstrap 4 validation messages not being colored red Fix the error state for Bootstrap 4 Fix TwitterBootstrap4 blockHelp Add default TwitterBootstrap4 config Adding support for Bootstrap 4 (formers#577) Add Choice field type Add field modifiers to store moethod signature metadata and postpone framework classes until render time Checkable allow setting inline, stacked, grouped via boolaen attribute Allow setting required via boolean attribute per formers#571 Update README.md Revert "Encode select options (formers#555)" ...
This adds pretty basic support for Bootstrap 4. Needed minor changes to the checkable trait to be able to support the way that Boostrap 4 renders the radio and checkbox fields.
Example Radio call: