Adds correct checkbox input class when is a checkbox (or radio) #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the default form-input class is used which isn't styling checkboxes or radios correctly
|
Thanks, @CedNet ! |
ricardosierra
added a commit
to SierraTecnologia/former
that referenced
this pull request
Jun 16, 2020
* 'master' of github.com:formers/former: (47 commits) Support Laravel 7 Fix errors when using rules in validation array Add tests Fix errors when using rules in validation array Laravel 6 support (formers#591) Adds correct checkbox input class when is a checkbox (or radio) (formers#590) Encode checkbox value to prevent XSS attack (formers#584) Fix the Bootstrap 4 help blocks Fix tabs vs spaces :) Fix Bootstrap 4 validation messages not being colored red Fix the error state for Bootstrap 4 Fix TwitterBootstrap4 blockHelp Add default TwitterBootstrap4 config Adding support for Bootstrap 4 (formers#577) Add Choice field type Add field modifiers to store moethod signature metadata and postpone framework classes until render time Checkable allow setting inline, stacked, grouped via boolaen attribute Allow setting required via boolean attribute per formers#571 Update README.md Revert "Encode select options (formers#555)" ...
tortuetorche
added a commit
to tortuetorche/former
that referenced
this pull request
Dec 30, 2020
E.g.
{!! Former::open()->method('GET') !!}
{!! Former::checkbox('test')->text('Test checkbox') !!}
{!! Former::close() !!}
Render:
<div class="form-check">
<input class="form-check-input" id="test" type="checkbox" name="test"
value="1">
<label for="test" class="form-check-label">Test checkbox</label>
</div>
References:
- formers#581
- formers#590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the default form-input class is used which isn't styling checkboxes or radios correctly