FIO-5566: Fixes an issue where deprication warning appears in the console when using Day component with dateFirst setting

src/components/day/Day.js

@@ -516,19 +516,12 @@ export default class DayComponent extends Field {
     return this.getDate();
   }
 
-  normalizeMinMaxDates() {
-   return [this.component.minDate, this.component.maxDate]
-      .map(date => date ? date.split('-').reverse().join('/') : date);
-  }
-
   /**
    * Return the raw value.
    *
    * @returns {Date}
    */
   get validationValue() {
-    [this.component.minDate, this.component.maxDate] = this.dayFirst ? this.normalizeMinMaxDates()
-      : [this.component.minDate, this.component.maxDate];
     return this.dataValue;
   }
 

src/components/day/Day.unit.js

@@ -162,9 +162,20 @@ describe('Day Component', () => {
     });
   });
 
-  it('should normalize min-max dates on dayFirst', () => {
+  it('Should properly validate min-max dates when dayFirst is checked', (done) => {
     Harness.testCreate(DayComponent, comp3).then((component) => {
-      assert.deepEqual(component.normalizeMinMaxDates(), ['04/02/2020', '09/02/2020']);
+      component.setValue('01/02/2020');
+      assert(!component.checkValidity(component.data, true), 'Component should not be valid');
+
+      component.setValue('04/01/2021');
+      assert(!component.checkValidity(component.data, true), 'Component should not be valid');
+
+      component.setValue('03/01/2021');
+      assert(component.checkValidity(component.data, true), 'Component should be valid');
+
+      component.setValue('01/03/2020');
+      assert(component.checkValidity(component.data, true), 'Component should be valid');
+      done();
     });
   });
 

src/components/day/fixtures/comp3.js

@@ -11,8 +11,8 @@ export default {
   'validate': {
     'custom': ''
   },
-  'minDate': '2020-02-04',
-  'maxDate': '2020-02-09',
+  'minDate': '2020-03-01',
+  'maxDate': '2021-01-03',
   'clearOnHide': true,
   'persistent': true,
   'protected': false,

src/utils/utils.js

@@ -469,7 +469,13 @@ export function getDateSetting(date) {
     return date.isValid() ? date.toDate() : null;
   }
 
-  let dateSetting = ((typeof date !== 'string') || (date.indexOf('moment(') === -1)) ? moment(date) : null;
+  let dateSetting = null;
+  if (typeof date !== 'string') {
+    dateSetting = moment(date);
+  }
+  else if (date.indexOf('moment(') === -1) {
+    dateSetting = moment(date, 'YYYY-MM-DD');
+  }
   if (dateSetting && dateSetting.isValid()) {
     return dateSetting.toDate();
   }