FIO-5566: Fixes an issue where deprication warning appears in the console when using Day component with dateFirst setting #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sole when using Day component with dateFirst setting
TanyaGashtold
requested changes
Mar 15, 2023
…y-min-max-date-validations-issue
…y-min-max-date-validations-issue
|
|
TanyaGashtold
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://formio.atlassian.net/browse/FIO-5566
There was a change done 2 years ago that was rewriting minDate and maxDate settings from the ISO format (yyyy-mm-dd) to another (dd/mm/yyyy) when the dayFirst setting was turned on. But due to the other changes in min/max date validation, this fix caused other issues where a deprication warning was shown and min/max date setting were read wrongly (eg. 2000-03-01 is supposted to be 1 March, 2000, but it was read as 3 January, 2000 instead) that was leading to min/max date validations were not always working properly.
How has this PR been tested?
The test written for rewriting min/maxDate setting to other format was replaced with a test checking that ensures min/max date validations works properly