Move Vanilla and Bootstrap into separate repos

[ghelton]

Moving this discussion out of #76.

As Formly grows in scope we need to keep the base library easily maintainable while leaving ourselves open for others to contribute plugins to the library. With this in mind all template builds should be moved into separate repos.

[kentcdodds]

This is an interesting idea... What do you think this would do to our development lifecycle? Would it complicate things to have to pull down multiple repos to make sure you didn't break something? Or should we just make sure we have a solid test suite?

One thing I like about this is that most of the issues reported on this repo are template related. It would be nice to make that clear separation... I'm leaning toward this idea...

[ghelton]

I think we'd just be creating several repos which depend on this one. It would be good for this one to mention the others and maybe the demo would use the bootstrap one. The real question is should we do this in 0.1.0 or move it to a future release? I'm going to be out for a couple weeks traveling soon, hopefully none of this requires my urgent help, but I'll try and jump in when I can. @kentcdodds do you have any desire to own those repos, or we could even create a new org i suppose? This is turning out to be quite the project :)

[kentcdodds]

I think that nimbly should create the bootstrap and vanilla repos. Then other people could create their own template "plugin" repos as needed. But we already have the templates for those so we should just keep those with nimbly. I don't think a new org is necessary.

I think we should take the opportunity with 0.1.0 to break as much as we need to get things where we want them to be right now. I'm hoping that the core will change very little after this, which is why I like splitting out the templates. Those repos will likely change a lot more than this one.

[mwawrusch]

why not do the right thing and create a free angular-formly organization
and group all products under this?

On Tue, Aug 26, 2014 at 2:16 PM, Kent C. Dodds notifications@github.com
wrote:

I think that nimbly should create the bootstrap and vanilla repos. Then
other people could create their own template "plugin" repos as needed. But
we already have the templates for those so we should just keep those with
nimbly. I don't think a new org is necessary.

I think we should take the opportunity with 0.1.0 to break as much as we
need to get things where we want them to be right now. I'm hoping that the
core will change very little after this, which is why I like splitting out
the templates. Those repos will likely change a lot more than this one.

—
Reply to this email directly or view it on GitHub
https://github.com/nimbly/angular-formly/issues/77#issuecomment-53493819
.

Martin Wawrusch
p: +1 310 404 1698

modeista.com - Connect With Style
fanignite.com - ALPHA - Create Your Mobile App In 30 Seconds
wawrusch.com - Personal Blog
codedoctor.co - Professional Blog

Follow me on twitter at @MartinWawrusch http://twitter.com/MartinWawrusch

[kentcdodds]

I'm fine with that. nbd

[ghelton]

Yeah I think I might do that, it'll make it easier to manage contributors and stuff.

[ghelton]

Hey all, this is finally in progress! Currently the templates are pointing to the latest hash for angular-formly. The template repos as I have them are dependent on angular-formly, unlike the current standalone builds. I think that this structure allows for us to release extended templates like an angular-bootstrap template that can live side by side with the base template. I think this is a great setup, the only part I don't like is having to generate this file each time:

angular.module('formly.render').config(function(formlyConfigProvider) {
    'use strict';
    var fields = [
        'textarea', 'radio', 'select', 'number', 'checkbox',
        'password', 'hidden', 'email', 'text'
    ];
    angular.forEach(fields, function(field) {
        formlyConfigProvider.setTemplateUrl(field, 'fields/formly-field-' + field + '.html');
    });
});

I feel like there might be a less verbose way of doing this, but I haven't thought of anything yet.

Next I'll be removing templates from angular-formly, release angular-formly, then update the template repos and release them.

Here are the repos:
https://github.com/formly-js/angular-formly-templates-vanilla
https://github.com/formly-js/angular-formly-templates-bootstrap

[kentcdodds]

Perhaps we could put that logic in formly-core? In the config provider just have a method called setupNormalTemplates or something and the template repos would have a config to do this? Just a thought.

[ghelton]

@kentcdodds sounds good. I'm going to leave it for now.

Templates are now removed from angular-formly. Final remaining thing is updating the docs in angular-formly to mention the other repos. I won't get to it today so if anyone else has time feel free.

[ghelton]

All done and released