Skip to content

Add clippy CI check to workflow #242

Add clippy CI check to workflow

Add clippy CI check to workflow #242

Triggered via pull request June 17, 2024 22:23
Status Failure
Total duration 5m 52s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 8 warnings
direct implementation of `ToString`: crates/types/src/transaction.rs#L68
error: direct implementation of `ToString` --> crates/types/src/transaction.rs:68:1 | 68 | / impl ToString for TransactionType { 69 | | fn to_string(&self) -> String { 70 | | match self { 71 | | TransactionType::BridgeIn(n) => format!("bridgeIn{n}"), ... | 77 | | } 78 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `-D clippy::to-string-trait-impl` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::to_string_trait_impl)]`
manual implementation of an assign operation: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs#L1681
error: manual implementation of an assign operation --> crates/types/src/token.rs:15:1 | 15 | / construct_uint! { 16 | | /// 256-bit unsigned integer. 17 | | #[derive(JsonSchema)] 18 | | #[serde(rename_all = "camelCase")] 19 | | pub struct U256(4); 20 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: this error originates in the macro `$crate::construct_uint` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)
manual implementation of an assign operation: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs#L1031
error: manual implementation of an assign operation --> crates/types/src/token.rs:15:1 | 15 | / construct_uint! { 16 | | /// 256-bit unsigned integer. 17 | | #[derive(JsonSchema)] 18 | | #[serde(rename_all = "camelCase")] 19 | | pub struct U256(4); 20 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: this error originates in the macro `$crate::construct_uint` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)
manual implementation of an assign operation: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs#L1010
error: manual implementation of an assign operation --> crates/types/src/token.rs:15:1 | 15 | / construct_uint! { 16 | | /// 256-bit unsigned integer. 17 | | #[derive(JsonSchema)] 18 | | #[serde(rename_all = "camelCase")] 19 | | pub struct U256(4); 20 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: this error originates in the macro `$crate::construct_uint` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)
manual implementation of an assign operation: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs#L1009
error: manual implementation of an assign operation --> crates/types/src/token.rs:15:1 | 15 | / construct_uint! { 16 | | /// 256-bit unsigned integer. 17 | | #[derive(JsonSchema)] 18 | | #[serde(rename_all = "camelCase")] 19 | | pub struct U256(4); 20 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: this error originates in the macro `$crate::construct_uint` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)
manual implementation of an assign operation: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uint-0.9.5/src/uint.rs#L1004
error: manual implementation of an assign operation --> crates/types/src/token.rs:15:1 | 15 | / construct_uint! { 16 | | /// 256-bit unsigned integer. 17 | | #[derive(JsonSchema)] 18 | | #[serde(rename_all = "camelCase")] 19 | | pub struct U256(4); 20 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `-D clippy::assign-op-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::assign_op_pattern)]` = note: this error originates in the macro `$crate::construct_uint` which comes from the expansion of the macro `construct_uint` (in Nightly builds, run with -Z macro-backtrace for more info)
clippy
Clippy had exited with the 101 exit code
fmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, baptiste0928/cargo-install@v2.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test workspace crates
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.