Skip to content

Add clippy CI check to workflow #251

Add clippy CI check to workflow

Add clippy CI check to workflow #251

Triggered via pull request June 17, 2024 23:05
Status Failure
Total duration 5m 46s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 8 warnings
direct implementation of `ToString`: crates/messages/src/actor_types.rs#L62
error: direct implementation of `ToString` --> crates/messages/src/actor_types.rs:62:1 | 62 | / impl ToString for SupervisorType { 63 | | fn to_string(&self) -> String { 64 | | match self { 65 | | SupervisorType::BlobCache => "blob_cache_supervisor".to_string(), ... | 78 | | } 79 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
direct implementation of `ToString`: crates/messages/src/actor_types.rs#L62
error: direct implementation of `ToString` --> crates/messages/src/actor_types.rs:62:1 | 62 | / impl ToString for SupervisorType { 63 | | fn to_string(&self) -> String { 64 | | match self { 65 | | SupervisorType::BlobCache => "blob_cache_supervisor".to_string(), ... | 78 | | } 79 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
direct implementation of `ToString`: crates/messages/src/actor_types.rs#L26
error: direct implementation of `ToString` --> crates/messages/src/actor_types.rs:26:1 | 26 | / impl ToString for ActorType { 27 | | fn to_string(&self) -> String { 28 | | match self { 29 | | ActorType::Registry => "registry".to_string(), ... | 44 | | } 45 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `-D clippy::to-string-trait-impl` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::to_string_trait_impl)]`
direct implementation of `ToString`: crates/messages/src/actor_types.rs#L26
error: direct implementation of `ToString` --> crates/messages/src/actor_types.rs:26:1 | 26 | / impl ToString for ActorType { 27 | | fn to_string(&self) -> String { 28 | | match self { 29 | | ActorType::Registry => "registry".to_string(), ... | 44 | | } 45 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl = note: `-D clippy::to-string-trait-impl` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::to_string_trait_impl)]`
clippy
Clippy had exited with the 101 exit code
fmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, baptiste0928/cargo-install@v2.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test workspace crates
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.