Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete hover of parameters variables #284

Closed
gbogopolsky opened this issue May 19, 2023 · 1 comment
Closed

Incomplete hover of parameters variables #284

gbogopolsky opened this issue May 19, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gbogopolsky
Copy link
Contributor

Describe the bug
When hovering over a variable that was defined as a computed parameter, only the first member of the computation shows up

To Reproduce
Define a computed parameter, use it in the code and hover over it.
If there is a space or "/" in the parameter definition, anything after will not show up.

real(8), parameter :: three = 1.0d0*3.0d0
real(8), parameter :: six = 2.0d0 * 3.0d0
real(8), parameter :: one = 1.0d0
real(8), parameter :: sixth = one / six
real(8), parameter :: third = one/three

On Hovering, one gets the following:

image
image
image
image
image

Except when there is a "*" without spaces, the second term of the computed parameter is always missing.

Expected behavior
I would expect the whole line to show up, until an endline character or the start of a comment.

Setup information (please complete the following information):

  • OS: Mac with Linux SSH Server
  • Python 3.8.1
  • fortls 2.13.0
  • VS Code
  • Modern Fortran v3.4.2023051701
@gbogopolsky gbogopolsky added the bug Something isn't working label May 19, 2023
@folk85
Copy link
Contributor

folk85 commented Jun 11, 2023

I suggest the solution of this bug. Add several tests. But pytest -v failed in one test test/test_interface.py::test_version_update_pypi.

folk85 added a commit to folk85/fortls that referenced this issue Jun 11, 2023
Add division sign, allow spaces in values of parameters. Extend
unittests.
folk85 added a commit to folk85/fortls that referenced this issue Jun 11, 2023
Add division sign, allow spaces in values of parameters. Extend
unittests with patameters variables
gnikit pushed a commit to folk85/fortls that referenced this issue Jun 12, 2023
Add division sign, allow spaces in values of parameters. Extend
unittests with patameters variables
gnikit added a commit that referenced this issue Jun 16, 2023
Issue #284 fix and extend hover of parameters.
@gnikit gnikit closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants