Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #284 fix and extend hover of parameters. #288

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

folk85
Copy link
Contributor

@folk85 folk85 commented Jun 11, 2023

Modify regex of parameter's values. Add division sign, allow spaces in values of parameters. Extend unittests with parameters variables.

@gnikit

@folk85 folk85 requested a review from gnikit as a code owner June 11, 2023 09:12
@gnikit
Copy link
Member

gnikit commented Jun 12, 2023

Cheers for the PR @folk85, I approved the runs and will have a look at it today. But in general it looks good.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #288 (6debd0e) into master (b604730) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          12       12           
  Lines        4569     4569           
=======================================
  Hits         3973     3973           
  Misses        596      596           
Impacted Files Coverage Δ
fortls/regex_patterns.py 100.00% <100.00%> (ø)

Add division sign, allow spaces in values of parameters. Extend
unittests with patameters variables
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @folk85 I had a chance to play around with your suggested changes and it looks good, however when the code is split amongst multiple lines the hover message looks quite strange.

image

The ideal resolution would be to trim the forward and trailing whitespaces for PARAMETER_VAL, but off the top of my head that might be a bit complicated for this PR.

Alternatively, I am thinking of approving and merging and addressing the problem in a later PR.

FYI certain compiler vendors tend to structure their source codes for certain modules like OpenMP with these kind of indentations

let me know what you think.

@folk85
Copy link
Contributor Author

folk85 commented Jun 12, 2023

@gnikit , thanks for the fast response. I also thought about many whitespaces, but I think it should be in separate issue and I have idea how to solve it.

@gnikit gnikit merged commit 17f03e4 into fortran-lang:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants