Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: hover multi-line parameter signature #291

Closed
gnikit opened this issue Jun 16, 2023 · 1 comment · Fixed by #293
Closed

bug: hover multi-line parameter signature #291

gnikit opened this issue Jun 16, 2023 · 1 comment · Fixed by #293
Labels
bug Something isn't working lsp/hover Issues related with hovering requests

Comments

@gnikit
Copy link
Member

gnikit commented Jun 16, 2023

Introduced via #288

image

The ideal resolution would be to trim the forward and trailing whitespaces for PARAMETER_VAL.

Originally posted by @gnikit in #288 (review)
@gnikit gnikit added bug Something isn't working lsp/hover Issues related with hovering requests labels Jun 16, 2023
folk85 added a commit to folk85/fortls that referenced this issue Jun 17, 2023
@folk85
Fix fortran-lang#291 hover multi-line parameter signature
86d8eb5 
Trim trailing whitespaces. Modify one test and add one more
parameter_val test with multiline definition.
@folk85
Copy link
Contributor

folk85 commented Jun 17, 2023

@gnikit, I suggest one solution, but I'm not sure that it is the correct place for implementation.

gnikit pushed a commit to folk85/fortls that referenced this issue Jun 22, 2023
@folk85 @gnikit
Fix fortran-lang#291 hover multi-line parameter signature
ff3e3e0 
Trim trailing whitespaces. Modify one test and add one more
parameter_val test with multiline definition.
@gnikit gnikit linked a pull request Jun 22, 2023 that will close this issue
Fix #291 hover multi-line parameter signature #293
Merged
gnikit added a commit that referenced this issue Jun 22, 2023
@gnikit
Merge pull request #293 from folk85/master
9e42210 
Fix #291 hover multi-line parameter signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lsp/hover Issues related with hovering requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #291 hover multi-line parameter signature folk85/fortls
2 participants
@folk85 @gnikit