Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search doesn't work in EventsFragment #1349

Closed
anhanh11001 opened this issue Mar 19, 2019 · 0 comments
Closed

Search doesn't work in EventsFragment #1349

anhanh11001 opened this issue Mar 19, 2019 · 0 comments

Comments

@anhanh11001
Copy link
Contributor

Describe the bug
Needs to reload in order for searching in EventsFragment works. This is due to my PR #1296, I know the cause of the problem so I will fix it

Screenshots

Would you like to work on the issue?
Yes
@anhanh11001 anhanh11001 mentioned this issue Mar 19, 2019
Merged
iamareebjamal pushed a commit that referenced this issue Mar 21, 2019
@anhanh11001 @iamareebjamal
fix: make search in EventsFragment works again (#1350)
d810bdd 
* Summary Change: Fix making search in EventsFragment works again

Details:
- Add a LiveData String to store the last search so that if a new search come, it reloads events again

Fix #1349

* Small Changes: initializing String object with ""
@addiegupta addiegupta mentioned this issue Mar 22, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anhanh11001