Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop reloading events after rotating screen #1296

Merged
merged 1 commit into from
Mar 16, 2019
Merged

fix: Stop reloading events after rotating screen #1296

merged 1 commit into from
Mar 16, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:
I add tags on loading events (RELOADING OR INITIAL LOADING). The events' list is only loaded again if the tag is RELOADING or INITIAL LOADING + the event list is not loaded before.

Fixes #1295

Screenshots for the change:

Details:
I add tags on loading events (RELOADING OR INITIAL LOADING). The events' list is only loaded again if the tag is RELOADING or INITIAL LOADING + the event list is not loaded before.

This resolves issue 1295
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is swipe refresh works fine?

@anhanh11001
Copy link
Contributor Author

@liveHarshit yes, it works because I put the tag RELOADING.

rootView.retry.setOnClickListener {
            val isNetworkConnected = isNetworkConnected(context)
            if (eventsViewModel.savedLocation != null && isNetworkConnected) {
                eventsViewModel.loadLocationEvents(RELOADING_EVENTS)
            }
            showNoInternetScreen(isNetworkConnected)
        }

@iamareebjamal iamareebjamal merged commit cfec446 into fossasia:development Mar 16, 2019
@anhanh11001 anhanh11001 deleted the 1295_reloading_event branch June 20, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants