Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object attributes being sent "null" in API requests #1621

Closed
RotBolt opened this issue Apr 16, 2019 · 0 comments · Fixed by #1759
Closed

Object attributes being sent "null" in API requests #1621

RotBolt opened this issue Apr 16, 2019 · 0 comments · Fixed by #1759

Comments

@RotBolt
Copy link

RotBolt commented Apr 16, 2019 •
edited
Loading

Describe the bug
Object attributes being sent "null" in API requests which doesn't handle null cases

To Reproduce
Try to create the order for free event and see the error message.
Check the body being sent to order API for placing order .
It results in HTTP 422

Expected behavior
Provide default values instead of null to required attributes

Additional context
Currently problem is found in OrdersAPI only. I would look into other API for this null case and handle them too.

For more context : follow the discussion here
#1610 (comment)

Would you like to work on the issue?

YES

Solution
i will look into api required attributes which doesn't handle null cases and give default values to them.
@anhanh11001 anhanh11001 mentioned this issue May 13, 2019
Merged
nikit19 pushed a commit that referenced this issue May 14, 2019
@anhanh11001 @nikit19
fix: Reset default value for order
b3cec1f 
Detail:
- Set default value of order to 0 instead of null

Fixes: #1621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Reset default value for order
1 participant
@RotBolt