Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset default value for order #1759

Merged
merged 2 commits into from
May 14, 2019
Merged

fix: Reset default value for order #1759

merged 2 commits into from
May 14, 2019

Conversation

anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented May 13, 2019

Detail:

  • Set default value of the order to 0 instead of null. This helps to book for free events.

Fixes: #1621, #1728

Even though the null amount problem is editted in the server with #5869, current Android app still get HTTP 422 UNPROCESSABLE ENTITY so I made this PR.

@auto-label auto-label bot added the fix label May 13, 2019
Copy link
Member

@nikit19 nikit19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fails

Detail:
- Set default value of order to 0 instead of null

Fixes: #1621
@nikit19 nikit19 merged commit b3cec1f into fossasia:development May 14, 2019
@anhanh11001 anhanh11001 deleted the 1621_null_api_order branch June 20, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object attributes being sent "null" in API requests
3 participants