feat: Add Pagination #1681

aggarwalpulkit596 · 2019-04-28T10:23:58Z

Fixes #84

Changes: Add Pagination for Searching Location Events

Screenshots for the change:
Infinite Scrolling

app/src/main/java/org/fossasia/openevent/general/event/EventsDataSourceFactory.kt

aggarwalpulkit596 · 2019-05-02T13:38:14Z

@iamareebjamal @nikit19 please do an initial review after that I'll be moving forward to integrate for similar and search event API calls

aggarwalpulkit596 · 2019-05-02T13:45:07Z

app/src/main/java/org/fossasia/openevent/general/event/EventsViewModel.kt

+
+            compositeDisposable += mutableEventsPaged
+                .subscribeOn(Schedulers.io())
+                .observeOn(AndroidSchedulers.mainThread())
                .doOnSubscribe {


doFinally Block is not working

Cannot get it, why it is not working!

@iamareebjamal can you tell why doFinally Block is not working here because of that shimmer layout do not stop everything else just works fine. is it because pagination requires continuous API calls to different pages?

@iamareebjamal please a little bit of help here

Will try locally today

Yes, please do. I'm not getting any time these days

@iamareebjamal i tried with calling doFinally in the data source class and it was working there,i might be right that it RxPagedList don't call doFinally as it subscribes again and again to fetch all the pages

i was searching for some solution the only way i found is to send a mutableprogress object to data source and update that on doFinally

I've pushed it but I don't think so it is the best possible method to implement it

Yeah, doFinally will never be called in case of Observable or Flowable because the stream is never completed

aggarwalpulkit596 · 2019-05-02T13:45:12Z

app/src/main/java/org/fossasia/openevent/general/event/EventsListAdapter.kt

@@ -57,7 +59,7 @@ class EventsListAdapter(
     * The function to call when the adapter has to be cleared of items
     */
    fun clear() {
-        this.submitList(emptyList())
+//        this.submitList()


how to pass empty paged list I couldn't get it

What is this emptyList() method returning earlier?

empty list returns a list whereas the adapter required a pagedlist

thinking to use
this.currentList?.clear()
would that work @liveHarshit

aggarwalpulkit596 · 2019-05-02T13:45:17Z

app/build.gradle

@@ -36,11 +36,11 @@ android {
            shrinkResources true
            minifyEnabled true
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
-            buildConfigField "String", "DEFAULT_BASE_URL", '"https://api.eventyay.com/v1/"'
+            buildConfigField "String", "DEFAULT_BASE_URL", '"https://open-event-api-dev.herokuapp.com/v1/"'


will be reverting this

aggarwalpulkit596 · 2019-05-03T08:10:45Z

@nikit19 any update on this

aggarwalpulkit596 · 2019-05-03T18:32:55Z

@iamareebjamal any update regarding this ?

iamareebjamal · 2019-05-04T05:09:37Z

Take peer reviews

aggarwalpulkit596 · 2019-05-04T05:24:23Z

@nikit19 @liveHarshit please review

liveHarshit · 2019-05-04T10:46:14Z

app/src/main/java/org/fossasia/openevent/general/event/EventsListAdapter.kt

@@ -57,7 +59,7 @@ class EventsListAdapter(
     * The function to call when the adapter has to be cleared of items
     */
    fun clear() {
-        this.submitList(emptyList())
+//        this.submitList()


What is this emptyList() method returning earlier?

liveHarshit · 2019-05-04T10:46:44Z

app/src/main/java/org/fossasia/openevent/general/event/EventsViewModel.kt

+
+            compositeDisposable += mutableEventsPaged
+                .subscribeOn(Schedulers.io())
+                .observeOn(AndroidSchedulers.mainThread())
                .doOnSubscribe {


Cannot get it, why it is not working!

liveHarshit · 2019-05-04T10:46:54Z

app/src/main/java/org/fossasia/openevent/general/event/topic/SimilarEventsFragment.kt

-        if (similarEventsListAdapter.currentList.size != similarEvents.size) similarEvents.shuffle()
-        similarEventsListAdapter.submitList(similarEvents)
+//        if (similarEventsListAdapter.currentList.size != similarEvents.size) similarEvents.shuffle()
+//        similarEventsListAdapter.submitList(similarEvents)


Will implement pagination here as well it uses same adapters event view holder

@iamareebjamal should i implement pagination here as well because this method won't no longer work as the adapter expects as pagedlist and we are passing a normal list here

And there would be a heavy network usage if I implement pagination here as well I suggest we should create a seperate adapter for this and use this as a normal list

@iamareebjamal updated

aggarwalpulkit596 · 2019-05-11T11:13:07Z

app/src/main/java/org/fossasia/openevent/general/event/EventsDataSource.kt

+            eventService.getEventsByLocationPaged(query, requestedPage)
+                .withDefaultSchedulers()
+                .doFinally {
+                    mutableProgress.value = false


would this approach be okay? i couldn't find any other method to get this working @iamareebjamal

What is getEventsByLocationPaged returning?

It is returning a Observable Paged List

You cannot use doFinally here, move this call inside subscribe

Okay but inside the individual call of page finally is working

Should i add a check using using pageNo if equal pageNo == 1 then update the value because we want to hide the shimmer only once

Yes, that's reasonable

aggarwalpulkit596 · 2019-05-13T15:02:58Z

app/src/main/java/org/fossasia/openevent/general/event/EventsViewModel.kt

@@ -60,6 +74,12 @@ class EventsViewModel(
        } else {
            mutableProgress.value = false
        }
+
+        mutableProgress.observeForever {


@iamareebjamal I can't observer in the ViewModel i guess. can i ?

No, use MediatorLiveData

@iamareebjamal updated

@iamareebjamal should I implement pagination for search events as well?

Build is failing. Yeah, implement that in other PR

There are some unrelated changes will undo them and fix spotless. Rest all good?

iamareebjamal · 2019-05-14T22:10:22Z

@anhanh11001 @liveHarshit Please test

liveHarshit · 2019-05-15T04:48:58Z

@iamareebjamal @aggarwalpulkit596 App is crashing while navigating to another fragment and press back button while loading -

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.eventyay.attendee, PID: 6821
    java.lang.IllegalArgumentException: This source was already added with the different observer
        at androidx.lifecycle.MediatorLiveData.addSource(MediatorLiveData.java:89)
        at org.fossasia.openevent.general.event.EventsViewModel.loadLocationEvents(EventsViewModel.kt:78)

liveHarshit · 2019-05-15T04:51:10Z

Also during loading events-

aggarwalpulkit596 · 2019-05-15T04:51:23Z

@liveHarshit will check

aggarwalpulkit596 · 2019-05-15T04:55:56Z

@iamareebjamal @aggarwalpulkit596 App is crashing while navigating to another fragment and press back button while loading -

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.eventyay.attendee, PID: 6821
    java.lang.IllegalArgumentException: This source was already added with the different observer
        at androidx.lifecycle.MediatorLiveData.addSource(MediatorLiveData.java:89)
        at org.fossasia.openevent.general.event.EventsViewModel.loadLocationEvents(EventsViewModel.kt:78)

not able to reproduce it @liveHarshit

liveHarshit · 2019-05-15T04:57:29Z

not able to reproduce it @liveHarshit

While loading goes to notification fragment and press back button. It's crashing in my device. Let me check again.

aggarwalpulkit596 · 2019-05-15T04:58:49Z

not able to reproduce it @liveHarshit

While loading goes to notification fragment and press back button. It's crashing in my device. Let me check again.
Yup i got it

aggarwalpulkit596 · 2019-05-19T10:26:41Z

@liveHarshit @iamareebjamal please review there is only issue now

Also during loading events-

this always shows up because previously observer was only called upon a valid api request not with paged list it is called as soon api call is made so we need to check additional param whether showShimmer is false or not, just an observable on event list can't work

liveHarshit · 2019-05-19T12:06:00Z

Please fix Travis also.

aggarwalpulkit596 · 2019-05-19T12:08:06Z

Probably a spotless error will fix it but please first check for any crashes 😅

liveHarshit · 2019-05-19T13:02:34Z

@aggarwalpulkit596 It is not showing upcoming events.

liveHarshit · 2019-05-19T13:02:53Z

check how swipe refresh is working. It is showing no events instead of shimmer during refreshing.

also

aggarwalpulkit596 · 2019-05-19T13:08:26Z

@aggarwalpulkit596 It is not showing upcoming events.

Oh the logic must have been changed i forgot will change the end point

aggarwalpulkit596 · 2019-05-19T13:08:50Z

check how swipe refresh is working. It is showing no events instead of shimmer during refreshing.

also

Forgot that will fix it rest all good ?

liveHarshit · 2019-05-19T13:14:49Z

I don't see Infinite Scrolling in my device.

aggarwalpulkit596 · 2019-05-19T13:28:35Z

Did you try with changing the base url ther aren't many events in the staging server try with prod server

liveHarshit · 2019-05-19T13:33:18Z

Did you try with changing the base url ther aren't many events in the staging server try with prod server

Yes I have tried with Singapore and Delhi location with the release API. For what location you are testing?

aggarwalpulkit596 · 2019-05-19T13:59:33Z

Wait let me share a gif with you

aggarwalpulkit596 · 2019-05-19T14:08:11Z

@liveHarshit

aggarwalpulkit596 · 2019-05-19T14:54:36Z

app/src/main/java/org/fossasia/openevent/general/event/EventsViewModel.kt

@@ -65,28 +88,14 @@ class EventsViewModel(
    fun isConnected(): Boolean = mutableConnectionLiveData.value ?: false

    fun clearEvents() {
-        mutableEvents.value = null
+
+       // mutableEventsPaged


@iamareebjamal couldn't find anything to clear this out please help out here

aggarwalpulkit596 · 2019-05-19T14:55:04Z

app/src/main/java/org/fossasia/openevent/general/event/EventService.kt

@@ -99,6 +99,18 @@ class EventService(
        }
    }

+    fun getEventsByLocationPaged(locationName: String?, page: Int): Single<List<Event>> {
+        val query = "[{\"name\":\"location-name\",\"op\":\"ilike\",\"val\":\"%$locationName%\"}," +


@liveHarshit updated query for upcoming events

aggarwalpulkit596 · 2019-05-19T14:57:04Z

@liveHarshit rest all good ?

liveHarshit · 2019-05-19T15:00:00Z

@liveHarshit rest all good ?

What is the minimum number of events required for infinite scrolling?

liveHarshit · 2019-05-19T15:02:38Z

Because after filtering events, I can list max 5 number of events and infinite scrolling is not working.
Also showing no events card before loading events in rv.

aggarwalpulkit596 · 2019-05-19T15:22:40Z

@liveHarshit rest all good ?

What is the minimum number of events required for infinite scrolling?

It is 6 but can be changed in config object and it is showing because of

@liveHarshit @iamareebjamal please review there is only issue now

Also during loading events-

this always shows up because previously observer was only called upon a valid api request not with paged list it is called as soon api call is made so we need to check additional param whether showShimmer is false or not, just an observable on event list can't work

aggarwalpulkit596 · 2019-05-19T15:23:30Z

app/src/main/java/org/fossasia/openevent/general/di/Modules.kt

+        PagedList
+            .Config
+            .Builder()
+            .setPageSize(10)


@liveHarshit it is 10

Okay. Then there are three bugs to solve that I've already told you.

I already @iamareebjamal for a little bit of assistance as i am unable to find anything for @liveHarshit you can also suggest something if you find anything 😅

Firstly you need to modify the logic for showing no events card and shimmer effect. Both are in conflicts right now.

Also how the swipe refresh is connected with both.

triggered with a zero size list

Oh, got it. So here we cannot compare the size of the list, but

hat whether the intial request is completer or not

In that case, can we check if there are no events?

Can only be checked after the first request is completed that is progress live data is set to false

Then show shimmer until the request will complete.

Also for swipe to refresh we need to clear the mutableEventsPaged but that is observable before it was a live data so its value can be set to null and I can't find anything to set it source factory to null or zero-sized list

Then show shimmer until the request will complete.

but that's the point I need to check 2 separate live data values and then work accordingly will find some workaround for that definitely but couldn't find anything for observable disposable.clear() would work I guess then?

aggarwalpulkit596 · 2019-05-24T07:28:38Z

@liveHarshit updated,everything is working fine now
Couldn't check though because test events have been deleted i guess

liveHarshit · 2019-05-24T07:32:42Z

@liveHarshit updated,everything is working fine now
Couldn't check though because test events have been deleted i guess

Please test it by removing the filter and change the debug API to release.

aggarwalpulkit596 · 2019-05-24T07:35:46Z

upcoming event filter? Cool

anhanh11001 · 2019-06-21T09:13:25Z

Any updates on this? If not then I'm taking this up as it is an issue listed in GSoC Milestones. @aggarwalpulkit596

aggarwalpulkit596 · 2019-06-21T09:56:54Z

Would wind up by end of the week

anhanh11001 · 2019-06-21T09:57:28Z

@aggarwalpulkit596 Thanks

iamareebjamal reviewed Apr 30, 2019

View reviewed changes

app/src/main/java/org/fossasia/openevent/general/event/EventsDataSourceFactory.kt Outdated Show resolved Hide resolved

aggarwalpulkit596 force-pushed the paging branch from 622903d to 7dda9c9 Compare May 1, 2019 19:46

fossasia deleted a comment May 1, 2019

aggarwalpulkit596 changed the title ~~[WIP]feat: Add Pagination[skip ci]~~ feat: Add Pagination May 2, 2019

auto-label bot added the feature label May 2, 2019

aggarwalpulkit596 force-pushed the paging branch from 7dda9c9 to b40fddd Compare May 2, 2019 13:37

aggarwalpulkit596 commented May 2, 2019

View reviewed changes

liveHarshit reviewed May 4, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the paging branch from b40fddd to 5cac47f Compare May 11, 2019 06:33

aggarwalpulkit596 commented May 11, 2019

View reviewed changes

aggarwalpulkit596 commented May 13, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the paging branch 5 times, most recently from d3d64b3 to 9c2fc88 Compare May 14, 2019 21:24

aggarwalpulkit596 force-pushed the paging branch from 77b9ad5 to add091f Compare May 19, 2019 14:42

aggarwalpulkit596 commented May 19, 2019

View reviewed changes

feat: Add Pagination

050d9d8

aggarwalpulkit596 force-pushed the paging branch from add091f to 050d9d8 Compare May 24, 2019 07:28

anhanh11001 mentioned this pull request Jun 28, 2019

feat: Add pagination #2012

Merged

iamareebjamal closed this in #2012 Jul 2, 2019

feat: Add Pagination #1681

feat: Add Pagination #1681

Conversation

aggarwalpulkit596 commented Apr 28, 2019 • edited Loading

aggarwalpulkit596 commented May 2, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 May 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented May 3, 2019

aggarwalpulkit596 commented May 3, 2019

iamareebjamal commented May 4, 2019

aggarwalpulkit596 commented May 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented May 14, 2019

liveHarshit commented May 15, 2019

liveHarshit commented May 15, 2019

aggarwalpulkit596 commented May 15, 2019

aggarwalpulkit596 commented May 15, 2019 • edited Loading

liveHarshit commented May 15, 2019

aggarwalpulkit596 commented May 15, 2019

aggarwalpulkit596 commented May 19, 2019

liveHarshit commented May 19, 2019 • edited Loading

aggarwalpulkit596 commented May 19, 2019 • edited Loading

liveHarshit commented May 19, 2019

liveHarshit commented May 19, 2019

aggarwalpulkit596 commented May 19, 2019

aggarwalpulkit596 commented May 19, 2019

liveHarshit commented May 19, 2019

aggarwalpulkit596 commented May 19, 2019

liveHarshit commented May 19, 2019

aggarwalpulkit596 commented May 19, 2019

aggarwalpulkit596 commented May 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented May 19, 2019

liveHarshit commented May 19, 2019

liveHarshit commented May 19, 2019

aggarwalpulkit596 commented May 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liveHarshit May 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aggarwalpulkit596 commented Apr 28, 2019 •

edited

Loading

aggarwalpulkit596 May 11, 2019 •

edited

Loading

aggarwalpulkit596 commented May 15, 2019 •

edited

Loading

liveHarshit commented May 19, 2019 •

edited

Loading

aggarwalpulkit596 commented May 19, 2019 •

edited

Loading

liveHarshit May 20, 2019 •

edited

Loading