feat: Add pagination #2012
Merged
feat: Add pagination #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
reviewed
Jun 27, 2019
| PagedList | ||
| .Config | ||
| .Builder() | ||
| .setPageSize(5) |
There was a problem hiding this comment.
so we are requesting for more data after 5 elements right? I guess this is too less. We can load 15-20 events at time if it doesn't take too much time to load.
There was a problem hiding this comment.
I think it is fine. Much better for mobile data. Will test locally
There was a problem hiding this comment.
@iamareebjamal did you test? This PR looks good otherwise, let's finalise it
Details: - Add pagination in EventsFragment Fixes: #84
iamareebjamal
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes #84
Fixes #1681
Screenshots for the change:
