Standardized Date and Time #5533

Saumyachitransh01 · 2020-11-09T05:00:33Z

Short description of what this resolves:

All the occurrence of dates and time has been converted to only 5 formats

Changes proposed in this pull request:

Since there were more than 20 formats used all over the platform, I've minimized it to use only 5 formats.
Five formats that are used everywhere including all .js files and .hbs files are:-

DD-MM-YYYY
ddd, DD MMMM, YYYY
hh:mm A
ddd, DD MMMM, YYYY hh:mm A
DD MMMM, YYYY hh:mm A

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-11-09T05:00:38Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lc0wwjz9w
✅ Preview: https://open-event-frontend-git-branchnew.eventyay.vercel.app

iamareebjamal · 2020-11-09T05:26:34Z

app/components/forms/wizard/basic-details-step.js

@@ -116,10 +116,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
    this.oldTimezone = this.data.event.timezone;
    if (!oldTimezone || !this.oldTimezone || oldTimezone === this.oldTimezone) {return}
    if (event.startsAt) {
-      event.startsAt = moment.tz(event.startsAt.clone().tz(oldTimezone).format('YYYY-MM-DDTHH:mm:ss.SSS'), moment.ISO_8601, this.data.event.timezone);
+      event.startsAt = moment.tz(event.startsAt.clone().tz(oldTimezone).format('DD MMMM, YYYY hh:mm A'), moment.ISO_8601, this.data.event.timezone);


This is not user facing format. This is ISO8601 format and it needs to remain same

iamareebjamal · 2020-11-09T05:27:26Z

app/components/schedule.hbs

@@ -15,10 +15,10 @@
    @viewName="agendaDay"
    @defaultView="timelineDay"
    @validRange={{this.validRange}}
-    @now={{moment-format (now) "YYYY-MM-DD"}}
+    @now={{moment-format (now) "DD-MM-YYYY"}}


This is not user facing format. This needs to be passed in the exact same way to the component

iamareebjamal · 2020-11-09T05:27:41Z

app/components/schedule.hbs

    @scrollTime="0:00:00"
    @slotDuration="00:05:00"
-    @slotLabelFormat="HH:mm"
+    @slotLabelFormat="hh:mm A"


Same. This should not be changed

Saumyachitransh01 · 2020-11-09T06:24:05Z

Okay, and apart from these three are there any other corrections needed?

iamareebjamal · 2020-11-09T06:40:58Z

@mariobehling Please check

mariobehling

Thank you very much! This is a huge improvement and seeing your changes I believe it would be even better, if we could further limit this to only two formats. Here is the list below.

Please do not add a "0" in front of single digit date or time formats.

This is good for tables:
Make event format as in this example: 4 Dec, 2020 5:00 PM (IST)

table https://eventyay.com/events
table https://eventyay.com/admin/events
table https://eventyay.com/admin/sales
table https://eventyay.com//admin/users/
table event orders table /events/[event ID]/tickets/orders
table event attebdees /events/[event ID]/tickets/attebdees
table session overview page events/[event ID]/sessions/all

This is good for most public pages
Make event format as in this example: Friday, 4 December, 2020 5:00 PM (IST)

tickets overview https://eventyay.com/my-tickets/past
ticket order https://eventyay.com/orders/[order number here]
events dashboard /events/[events ID]
public events page header e/[eventpage], e.g. https://eventyay.com/e/a315169f
public events page ticket section, e.g. https://eventyay.com/e/a315169f#tickets
public events page calendar section
call for speakers, e.g. https://eventyay.com/e/a315169f/cfs

Am I missing something important? Please share if any.

Saumyachitransh01 · 2020-11-10T00:30:50Z

And places like these? Having the format "MM/DD/YYYY". Which one of those two formats should I use?

iamareebjamal · 2020-11-10T00:52:56Z

4 Dec, 2020

iamareebjamal · 2020-11-10T12:05:07Z

app/components/schedule.hbs

@@ -18,7 +18,7 @@
    @now={{moment-format (now) "YYYY-MM-DD"}}
    @scrollTime="0:00:00"
    @slotDuration="00:05:00"
-    @slotLabelFormat="HH:mm"
+    @slotLabelFormat="HH:MM"


Again, this is not for public display.

iamareebjamal · 2020-11-10T12:06:03Z

app/components/forms/wizard/basic-details-step.js

@@ -465,7 +465,7 @@ export default Component.extend(FormMixin, EventWizardMixin, {
      eventStartDate = moment(new Date(eventStartDate));
      this.data.event.tickets.forEach(ticket => {
        if (moment(eventStartDate).isBefore(ticket.get('salesEndsAt'))) {
-          ticket.set('salesEndsAt', moment(eventStartDate, 'MM/DD/YYYY').toDate());
+          ticket.set('salesEndsAt', moment(eventStartDate, 'DD-MMMM-YYYY').toDate());


Hmm, where did this format come from? And this is not for public display

iamareebjamal · 2020-11-10T12:06:32Z

Please don't change formats which are used for parsing and not for display

Saumyachitransh01 · 2020-11-10T13:15:29Z

Please don't change formats which are used for parsing and not for display

So should I only change hbs and not js?

iamareebjamal · 2020-11-10T22:53:39Z

JS contains display formats as well. And the build is failing. The initial work was much more stable. I don't know what triggered the need for editing each file one at a time. You already had another PR ready. You could just force push the changes on this branch

iamareebjamal · 2020-11-10T22:57:32Z

I have forced pushed the changes from other PR to this. Please delete the local branch and fetch again to continue the work.

git checkout development
git branch -D branchNew
git fetch origin branchNew
git checkout branchNew

Saumyachitransh01 · 2020-11-11T11:51:46Z

Please don't change formats which are used for parsing and not for display

It's a bit confusing, how to determine which one is for parsing and which is for display

Please confirm if this is for display or not?

iamareebjamal · 2020-11-11T12:40:01Z

It is a display format

mariobehling · 2020-11-21T14:27:01Z

Hi, would be great if this PR gets finalized. As this PR is blocking others from resolving the issue, we would close it in the upcoming days if there is no activity. You already contributed a good amount of time to this PR, so I think with some more effort you could finalize it. Keep it up!

codecov · 2020-11-22T07:56:11Z

Codecov Report

Merging #5533 (a584d34) into development (7c4f3e8) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5533      +/-   ##
===============================================
- Coverage        23.71%   23.60%   -0.12%     
===============================================
  Files              510      510              
  Lines             5422     5422              
  Branches            59       59              
===============================================
- Hits              1286     1280       -6     
- Misses            4121     4126       +5     
- Partials            15       16       +1

Impacted Files	Coverage Δ
app/controllers/account/billing/invoices/list.js	`100.00% <ø> (ø)`
app/controllers/admin/messages/list.js	`0.00% <ø> (ø)`
app/controllers/admin/sales/invoices.js	`0.00% <ø> (ø)`
app/controllers/admin/sessions/list.js	`0.00% <ø> (ø)`
app/controllers/admin/users/list.js	`0.00% <ø> (ø)`
app/controllers/events/list.js	`23.07% <ø> (ø)`
app/controllers/events/view/sessions/list.js	`0.00% <ø> (ø)`
app/controllers/events/view/tickets/orders/list.js	`0.00% <ø> (ø)`
app/components/tabbed-navigation.js	`33.33% <0.00%> (-20.00%)`	⬇️
app/services/cache.ts	`64.15% <0.00%> (-5.67%)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4f3e8...a584d34. Read the comment docs.

iamareebjamal · 2020-11-22T08:22:06Z

app/helpers/header-date.js

@@ -3,7 +3,7 @@ import moment from 'moment';

 export function headerDate(params) {
  const timezone = params[1] ? params[1] : moment.tz.guess();
-  return `${moment(params[0]).tz(timezone).format('dddd, D MMMM, YYYY h:mm A')} (${moment.tz(params[0], timezone).zoneAbbr()})`;
+  return `${moment(params[0]).tz(timezone).format('dddd, MMMM Do YYYY, h:mm A')} (${moment.tz(params[0], timezone).zoneAbbr()})`;


Why reverted the format here? We need same format everywhere

This was the only way for the build to be successful.
Changing it was failing the build every time.

No, that's not the only way to fix the build

mariobehling · 2020-11-27T17:10:33Z

This has been resolved already elsewhere now. Thank you

vercel bot deployed to Preview November 9, 2020 05:00 View deployment

iamareebjamal reviewed Nov 9, 2020

View reviewed changes

mariobehling requested changes Nov 9, 2020

View reviewed changes

Standardized Date and Time

6478761

vercel bot deployed to Preview November 10, 2020 11:49 View deployment

vercel bot deployed to Preview November 10, 2020 11:53 View deployment

vercel bot deployed to Preview November 10, 2020 11:58 View deployment

vercel bot deployed to Preview November 10, 2020 12:02 View deployment

iamareebjamal reviewed Nov 10, 2020

View reviewed changes

vercel bot had a problem deploying to Preview November 10, 2020 12:06 Failure

vercel bot had a problem deploying to Preview November 10, 2020 12:08 Failure

vercel bot had a problem deploying to Preview November 10, 2020 12:10 Failure

vercel bot had a problem deploying to Preview November 10, 2020 12:22 Failure

vercel bot had a problem deploying to Preview November 10, 2020 12:33 Failure

iamareebjamal force-pushed the branchNew branch from 4f2d778 to 6478761 Compare November 10, 2020 22:55

iamareebjamal mentioned this pull request Nov 10, 2020

fix: Admin panel member since changed to date #5562

Merged

5 tasks

Time zone added

085b778

vercel bot deployed to Preview November 12, 2020 14:47 View deployment

vercel bot deployed to Preview November 12, 2020 15:39 View deployment

vercel bot deployed to Preview November 12, 2020 15:57 View deployment

Saumyachitransh01 force-pushed the branchNew branch from b16b8c6 to 085b778 Compare November 16, 2020 10:25

vercel bot deployed to Preview November 21, 2020 17:38 View deployment

Saumyachitransh01 force-pushed the branchNew branch from be0ddb8 to 085b778 Compare November 21, 2020 18:09

vercel bot deployed to Preview November 21, 2020 18:11 View deployment

format

79f9880

Saumyachitransh01 force-pushed the branchNew branch from 79552f2 to 79f9880 Compare November 21, 2020 18:34

vercel bot deployed to Preview November 21, 2020 18:34 View deployment

Merge branch 'development' into branchNew

82671fb

vercel bot deployed to Preview November 21, 2020 18:38 View deployment

edit

228e878

vercel bot deployed to Preview November 22, 2020 03:56 View deployment

Update header-date.js

a352eff

vercel bot deployed to Preview November 22, 2020 07:43 View deployment

Update general-date.js

a584d34

vercel bot deployed to Preview November 22, 2020 07:46 View deployment

iamareebjamal reviewed Nov 22, 2020

View reviewed changes

mariobehling closed this Nov 27, 2020

Saumyachitransh01 deleted the branchNew branch January 5, 2021 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standardized Date and Time #5533

Standardized Date and Time #5533

Saumyachitransh01 commented Nov 9, 2020

vercel bot commented Nov 9, 2020 •

edited

Loading

iamareebjamal Nov 9, 2020

iamareebjamal Nov 9, 2020

iamareebjamal Nov 9, 2020

Saumyachitransh01 commented Nov 9, 2020

iamareebjamal commented Nov 9, 2020

mariobehling left a comment

Saumyachitransh01 commented Nov 10, 2020

iamareebjamal commented Nov 10, 2020

iamareebjamal Nov 10, 2020

iamareebjamal Nov 10, 2020

iamareebjamal commented Nov 10, 2020

Saumyachitransh01 commented Nov 10, 2020

iamareebjamal commented Nov 10, 2020

iamareebjamal commented Nov 10, 2020

Saumyachitransh01 commented Nov 11, 2020

iamareebjamal commented Nov 11, 2020

mariobehling commented Nov 21, 2020

codecov bot commented Nov 22, 2020 •

edited

Loading

iamareebjamal Nov 22, 2020

Saumyachitransh01 Nov 22, 2020

iamareebjamal Nov 22, 2020

mariobehling commented Nov 27, 2020

Standardized Date and Time #5533

Standardized Date and Time #5533

Conversation

Saumyachitransh01 commented Nov 9, 2020

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

vercel bot commented Nov 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Saumyachitransh01 commented Nov 9, 2020

iamareebjamal commented Nov 9, 2020

mariobehling left a comment

Choose a reason for hiding this comment

Saumyachitransh01 commented Nov 10, 2020

iamareebjamal commented Nov 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented Nov 10, 2020

Saumyachitransh01 commented Nov 10, 2020

iamareebjamal commented Nov 10, 2020

iamareebjamal commented Nov 10, 2020

Saumyachitransh01 commented Nov 11, 2020

iamareebjamal commented Nov 11, 2020

mariobehling commented Nov 21, 2020

codecov bot commented Nov 22, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mariobehling commented Nov 27, 2020

vercel bot commented Nov 9, 2020 •

edited

Loading

codecov bot commented Nov 22, 2020 •

edited

Loading