Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Admin panel member since changed to date #5562

Merged
merged 1 commit into from
Nov 11, 2020
Merged

fix: Admin panel member since changed to date #5562

merged 1 commit into from
Nov 11, 2020

Conversation

codedsun
Copy link
Contributor

@codedsun codedsun commented Nov 10, 2020 •
edited
Loading

Fixes #5542 fix: Admin panel member since changed to date

Changes:
image

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dx58860la
✅ Preview: https://open-event-frontend-git-member.eventyay.vercel.app

@auto-label auto-label bot added the fix label Nov 10, 2020
@codedsun
Copy link
Contributor Author

@iamareebjamal - Review!

@codecov
Copy link

codecov bot commented Nov 10, 2020 •
edited
Loading

Codecov Report

Merging #5562 (e03b194) into development (cbf8e2a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5562   +/-   ##
============================================
  Coverage        23.71%   23.71%           
============================================
  Files              498      498           
  Lines             5255     5255           
  Branches            44       44           
============================================
  Hits              1246     1246           
  Misses            4003     4003           
  Partials             6        6
Impacted Files Coverage Δ
app/controllers/admin/users/list.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf8e2a...e03b194. Read the comment docs.

mariobehling
mariobehling requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change 24 hour format + AM/PM to 12 hour format + AM/PM

@iamareebjamal
Copy link
Member

Please use the format decided in #5533

@codedsun
Copy link
Contributor Author

image

Done @mariobehling @iamareebjamal

@iamareebjamal
Copy link
Member

Is that the format mentioned here? #5533 (review)

@codedsun
Copy link
Contributor Author

codedsun commented Nov 11, 2020 •
edited
Loading

@iamareebjamal - Now is it correct?

image

Also IST should be harcoded?

@iamareebjamal
Copy link
Member

No need of IST

iamareebjamal
iamareebjamal reviewed Nov 11, 2020
View reviewed changes
open-event-frontend.iml Outdated
<orderEntry type="inheritedJdk" />
<orderEntry type="sourceFolder" forTests="false" />
</component>
</module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@codedsun
Copy link
Contributor Author

Done @iamareebjamal

@mariobehling
Copy link
Member

No trailing 0 please. Use 7 Nov, instead of 07 Nov.

@mariobehling
Copy link
Member

Use 4:00 PM instead of 04:00 PM.

@codedsun
Copy link
Contributor Author

codedsun commented Nov 11, 2020 •
edited
Loading

image

@mariobehling @iamareebjamal

@codedsun
Copy link
Contributor Author

@iamareebjamal Can this be merged?

@iamareebjamal iamareebjamal merged commit ac3ce5d into fossasia:development Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling requested changes

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Pages: Change "Member Since" to date
3 participants
@codedsun @iamareebjamal @mariobehling