Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter attendees when ticket holder is not ticket purchaser #7471

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

codedsun
Copy link
Contributor

Fixes #7397

Short description of what this resolves:

feat: Filter attendees when ticket holder is not ticket purchaser

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #7471 (9098e01) into development (280ac5b) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7471      +/-   ##
===============================================
- Coverage        65.41%   65.38%   -0.03%     
===============================================
  Files              265      265              
  Lines            13244    13252       +8     
===============================================
+ Hits              8663     8665       +2     
- Misses            4581     4587       +6     
Impacted Files Coverage Δ
app/api/attendees.py 55.64% <0.00%> (-0.92%) ⬇️
app/api/schema/orders.py 96.82% <ø> (ø)
app/models/order.py 84.78% <33.33%> (-3.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280ac5b...9098e01. Read the comment docs.

@iamareebjamal iamareebjamal changed the title feat: Filter attendees when ticket holder is not ticket purchaser fix: Filter attendees when ticket holder is not ticket purchaser Nov 26, 2020
@iamareebjamal iamareebjamal merged commit f0672e6 into fossasia:development Nov 26, 2020
@auto-label auto-label bot added fix and removed feature labels Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket PDF should exist for each attendee
2 participants