Bugfix for job visual-regression-test-init (Reverts quickfix #863) #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the errors found in #856 that occurred in the initialization stage of the cypress visual regression tests.
Description
These tests should in theory take screenshots on the master branch and compare to the changes done in the respective PR.
In reality, the test did use the built Javascript files of the PR instead and thus compared it to itself due to a missing flag (
loadprbuild: false
) in the github action.How Has This Been Tested?
I've done multiple tests on my fork. Using this change, the initialization did not fail anymore for the PR #856. (There are other errors however later in testing that I still need to fix, related to the changes there).
Types of changes
Checklist: