Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for job visual-regression-test-init (Reverts quickfix #863) #866

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

da-h
Copy link
Contributor

@da-h da-h commented Sep 16, 2022

This PR fixes the errors found in #856 that occurred in the initialization stage of the cypress visual regression tests.

Description

These tests should in theory take screenshots on the master branch and compare to the changes done in the respective PR.
In reality, the test did use the built Javascript files of the PR instead and thus compared it to itself due to a missing flag (loadprbuild: false) in the github action.

How Has This Been Tested?

I've done multiple tests on my fork. Using this change, the initialization did not fail anymore for the PR #856. (There are other errors however later in testing that I still need to fix, related to the changes there).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@da-h da-h changed the title (Reverts quickfix #863) Bugfix for job visual-regression-test-init (Reverts quickfix #863) Sep 16, 2022
@da-h da-h mentioned this pull request Sep 17, 2022
7 tasks
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for finding and resolving this!

@JackUrb JackUrb merged commit debae06 into fossasia:master Sep 19, 2022
@da-h da-h deleted the fix_workflow_job_cypress_init branch September 19, 2022 16:13
@da-h
Copy link
Contributor Author

da-h commented Sep 19, 2022

But to be fair, it was me who introduced the mistake in the first place. 😅

@da-h da-h mentioned this pull request Sep 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants