Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for job visual-regression-test-init (Reverts quickfix #863) #866

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Bugfix for job visual-regression-test-init (Reverts quickfix #863) #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03052bb
Revert "test: hotfix for failing click-event (possibly due to concurr…
Sep 16, 2022
e02c60e
github: fix workflow job "visual-regression-test-init"
Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/process-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ jobs:
- uses: ./.github/actions/prepare
with:
usebasebranch: true
loadprbuild: false

- name: "Checkout Tests from Head-Ref"
shell: bash
Expand Down
6 changes: 3 additions & 3 deletions cypress/integration/screenshots.init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ describe(`Take screenshot for PlotPane functions`, () => {
seed: 43,
});
cy.open_env(env1);
cy.get('button[title="smooth lines"]').click({ multiple: true }); // should be single element, concurrency (?) has triggered error here
cy.get('button[title="smooth lines"]').click();
cy.get('input[type="range"]').then(($range) => {
const range = $range[0]; // get the DOM node
const nativeInputValueSetter = Object.getOwnPropertyDescriptor(
Expand All @@ -80,7 +80,7 @@ describe(`Take screenshot for PlotPane functions`, () => {

it('Screenshot for Property Change (using Line Plot)', () => {
cy.run('plot_line_basic');
cy.get('button[title="properties"]').click({ multiple: true }); // should be single element, concurrency (?) has triggered error here
cy.get('button[title="properties"]').click();

// change some settings
const change = (key, val) =>
Expand All @@ -107,7 +107,7 @@ describe(`Take screenshot for PlotPane functions`, () => {
change('xaxis.type', 'log');

// apply settings
cy.get('button[title="properties"]').click({ multiple: true }); // should be single element, concurrency (?) has triggered error here
cy.get('button[title="properties"]').click();

const run = 'change-properties';
cy.get('.content').first().screenshot(run, { overwrite: true });
Expand Down
6 changes: 3 additions & 3 deletions cypress/integration/screenshots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe(`Compare screenshots for plotpane functions`, () => {
seed: 43,
});
cy.open_env(env1);
cy.get('button[title="smooth lines"]').click({ multiple: true }); // should be single element, concurrency (?) has triggered error here
cy.get('button[title="smooth lines"]').click();
cy.get('input[type="range"]').then(($range) => {
const range = $range[0]; // get the DOM node
const nativeInputValueSetter = Object.getOwnPropertyDescriptor(
Expand Down Expand Up @@ -178,7 +178,7 @@ describe(`Compare screenshots for plotpane functions`, () => {

it('Compare screenshot for Property Change (using Line Plot)', () => {
cy.run('plot_line_basic');
cy.get('button[title="properties"]').click({ multiple: true }); // should be single element, concurrency (?) has triggered error here
cy.get('button[title="properties"]').click();

// change some settings
const change = (key, val) =>
Expand All @@ -205,7 +205,7 @@ describe(`Compare screenshots for plotpane functions`, () => {
change('xaxis.type', 'log');

// apply settings
cy.get('button[title="properties"]').click({ multiple: true }); // should be single element, concurrency (?) has triggered error here
cy.get('button[title="properties"]').click();

const run = 'change-properties';
const diff_src =
Expand Down