Merge pull request #10871 from colin-marshall/fix/accordion-duplicate…

…-id-10870 fix: fix duplicate id's on accordion when id is already set on <li> elements
foundation · Jan 21, 2018 · 4f95271 · 4f95271
2 parents 40d6ec8 + dd020a7
commit 4f95271
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/js/foundation.accordion.js b/js/foundation.accordion.js
@@ -47,7 +47,7 @@ class Accordion extends Plugin {
       var $el = $(el),
           $content = $el.children('[data-tab-content]'),
           id = $content[0].id || GetYoDigits(6, 'accordion'),
-          linkId = el.id || `${id}-label`;
+          linkId = (el.id) ? `${el.id}-label` : `${id}-label`;
 
       $el.find('a:first').attr({
         'aria-controls': id,