fix: fix duplicate id's on accordion when id is already set on <li> elements #10871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-marshall
changed the title
ncoden
approved these changes
Jan 20, 2018
|
Travis tests fails but this is unrelated to this issue. |
|
Summary of a private discussion: tests run well locally. |
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…uplicate-id-10870 for v6.5.0 dd020a7 Fixed duplicate id's on accordion when id is already set on <li> elements Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
ghost
mentioned this pull request
SassNinja
added a commit
to SassNinja/foundation-sites
that referenced
this pull request
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem described in #10870.
Added
-labelto the end of the id on the<a>element when the id is previously set on its parent<li>element to avoid duplicate id's.