-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.4.1 – src/assets/js/custom.js
not included anymore like in 6.3.1?
#10353
Comments
Hi @Moonbase59 - can you clarify, are you talking about in the ZURB stack? If so, the answer is yes it has shifted b/c it's moved to using true module dependency, and we need to update the docs. Can you highlight the ones in particular you're seeing the outdated info on? Thanks! |
@kball http://foundation.zurb.com/sites/docs/starter-projects.html#javascript-compilation Any easy way to do this correctly in 6.4.1, a link maybe? |
@Moonbase59 essentially you'll want to simply import/require the files you want to include. I believe webpack allows you to do either node style require/exports (http://openmymind.net/2012/2/3/Node-Require-and-Exports/) or ES6 modules: http://exploringjs.com/es6/ch_modules.html Will hopefully have time to update docs soon, but if you get things working well and want to submit a PR to update those, that would be AWESOME :) |
Going to close this based on the initial docs improvement, but we'll be continuing to work on those docs as we go. |
A little nudge to see if you're getting any nearer improving those docs ? I stumbled across this problem today trying to work with the "new" FontAwesome 5 (https://fontawesome.com/get-started/svg-with-js). Putting |
Same issue as @udf2457 |
Changes: * Add infos about webpack * Add infos about Babel * Update recommended import process * Change list of useful resources Closes foundation#10353
@scottshuffler @udf2457 @Moonbase59 I updated the docs. See #10925. Does it solves your problem ? Is the docs clear enough now ? |
…cript-doc-10353 docs: update ZURB template JavaScript docs #10353
@ncoden LGTM |
…te-javascript-doc-10353 for v6.5.0 8d92c80 docs: update ZURB template JavaScript docs foundation#10353 9c2f818 docs: fix typo in starter project docs Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
The docs still say that all custom javascript files in
src/assets/js/
automatically get included intoapp.js
(6.3.1 did) but it seems not to? Anything changed due to webpack?[F6.4.1/SASS on Ubuntu]
The text was updated successfully, but these errors were encountered: