Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update ZURB template JavaScript docs #10353 #10925

Merged
merged 2 commits into from
Feb 10, 2018
Merged

docs: update ZURB template JavaScript docs #10353 #10925

merged 2 commits into from
Feb 10, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Feb 9, 2018

Changes:

  • Add infos about webpack
  • Add infos about Babel
  • Update recommended import process
  • Change list of useful resources

Closes #10353

@ncoden
docs: update ZURB template JavaScript docs foundation#10353
8d92c80 
Changes:
* Add infos about webpack
* Add infos about Babel
* Update recommended import process
* Change list of useful resources

Closes foundation#10353
@ncoden ncoden mentioned this pull request Feb 9, 2018
Closed
@JeremyEnglert
Copy link

@ncoden - this looks great to me.

Couple of notes:

  • I noticed you used "Javascript", while most of the docs seem to use the camelcase "JavaScript"
  • Should "Js" be "JS"?
  • I see "Webpack" and "WebPack"
  • The first sentence has an extra "and" in it. "Javascript is transpiled using and Babel (with the es2015 plugin) so you can use ES2015 features."
  • Missing "s" in "compiles" - "...it manages all assets and dependencies for you and compile them into one single file..."

@ncoden
Copy link
Contributor Author

ncoden commented Feb 10, 2018

I have really No Idea (and no opinion) about "Javascript"/"JavaScript"/"Webpack"/"WebPack". Thank you for the typo review. 👍

@JeremyEnglert
Copy link

No, no, no. Thank YOU for fixing these. Great work!

@ncoden
Copy link
Contributor Author

ncoden commented Feb 10, 2018 •
edited
Loading

So in the webpack https://webpack.js.org/ and repo they say webpack, and according to StackOverflow and Wikipedia we should say JavaScript.

@ncoden
Copy link
Contributor Author

ncoden commented Feb 10, 2018

@JeremyEnglert Fixed.

@JeremyEnglert
Copy link

Looks perfect!

@ncoden ncoden merged commit 8f898c9 into foundation:master Feb 10, 2018
@JeremyEnglert JeremyEnglert mentioned this pull request Feb 11, 2018
Closed
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#10925 from ncoden/docs/update-zurb-templa…
ad6c9eb 
…te-javascript-doc-10353 for v6.5.0

8d92c80 docs: update ZURB template JavaScript docs foundation#10353
9c2f818 docs: fix typo in starter project docs

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📖 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncoden @JeremyEnglert