-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with Tooltip docs #11054
Comments
* `[aria-haspopup]` is not recommanded for tooltips * `.has-tip` class is automatically added * `[data-click-open=false]` is not needed as `clickOpen` has for default value `false` See foundation#11054
fix: fix Tooltip cleaning on destroy #11054
Does anyone know why the |
tabindex is for a11y and tabbing support. |
I know – I'm asking specifically about what it does in this case. 🙂 |
It makes it accessible for screenreaders and people with assistive solutions. |
I've found the answer. Without the |
Right, that's what I've meant with "assistive solutions" like the OSD (onscreen keyboard) and other things like keyboard users (specific person groups). |
I guess this can be closed. |
From the example provided:
aria-haspopup="true"
According to this doc, this attribute is not applicable to tooltips:
class="has-tip"
This class is added automatically, so it seems unnecessary unless you want to ensure that the CSS is applied even if the JS fails to execute (but then the tooltip, at least the Foundation one, would not show anyway).
data-disable-hover="false"
This is the default value, so it's unnecessary to include it.
tabindex="1"
It would be good to document this. I don't really understand its purpose.
The text was updated successfully, but these errors were encountered: