Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: simplify & improve tooltip docs #11057

Merged
merged 3 commits into from
Mar 20, 2018
Merged

docs: simplify & improve tooltip docs #11057

merged 3 commits into from
Mar 20, 2018
+39 −43

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Mar 15, 2018

Changes:

  • remove useless attributes in Tooltip docs (they are added automatically)
  • simplify and improve Tooltip examples: use shorter paragraphs & repositions tooltips

See #11054

ncoden added 2 commits March 15, 2018 09:12
@ncoden
docs: remove useless attributes in Tooltip docs
979de14 
* `[aria-haspopup]` is not recommanded for tooltips
* `.has-tip` class is automatically added
* `[data-click-open=false]` is not needed as `clickOpen` has for default value `false`

See foundation#11054
@ncoden
docs: simplify and improve Tooltip examples
6b83ddf
@ncoden ncoden mentioned this pull request Mar 15, 2018
Closed
@DanielRuf
Copy link
Contributor

Which HEAD revision did you use for creating the branch? I guess this is still an old one without the new Chrome headless solution ;-)

@ncoden
Copy link
Contributor Author

ncoden commented Mar 15, 2018 •
edited
Loading

I thought I was up-to-date :/

@ncoden
Copy link
Contributor Author

ncoden commented Mar 15, 2018 •
edited
Loading

Ah no sorry. This is master. So tests are still broke on it.

@DanielRuf
Copy link
Contributor

DanielRuf commented Mar 15, 2018 •
edited
Loading

Ah no sorry. This is master. So tests are still broke on it.

Ah right, sorry. Totally forgot that it is just in develop so far and we did not cherrypick the change from develop into master. My bad.

@DanielRuf
Copy link
Contributor

Ah right, sorry. Totally forgot that it is just in develop so far and we did not cherrypick the change from develop into master. My bad.

Should we wait until the final merge or cherrypick them before to have a working testsuite on both main branches?

@ncoden
Copy link
Contributor Author

ncoden commented Mar 15, 2018

I guess we can cherry-pick. You can open a PR if you want.

@DanielRuf DanielRuf mentioned this pull request Mar 15, 2018
Merged
@ncoden ncoden requested a review from DanielRuf March 16, 2018 20:56
@ncoden ncoden merged commit edeac0d into foundation:master Mar 20, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11057 from ncoden/docs/simplify-tooltip-d…
b99fb87 
…ocs for v6.5.0

979de14 docs: remove useless attributes in Tooltip docs
6b83ddf docs: simplify and improve Tooltip examples

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf

Assignees
No one assigned
Labels
📖 documentation Tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncoden @DanielRuf