Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdowns have broken ARIA labelledby #11572

Closed
3 tasks done
silenceway opened this issue Nov 1, 2018 · 1 comment · Fixed by #11573
Closed
3 tasks done

Dropdowns have broken ARIA labelledby #11572

silenceway opened this issue Nov 1, 2018 · 1 comment · Fixed by #11573
Labels
accessibility Dropdown PR open
Milestone
6.5.1

Comments

@silenceway
Copy link

silenceway commented Nov 1, 2018 •
edited
Loading

What should happen?

aria-labelledby must point to label in dropdowns.

What happens instead?

It's creating labelledby attribute but without point to the label.

Possible Solution

Add id to this.$currentAnchor when created with GetYoDigits function.

Test Case and/or Steps to Reproduce (for bugs)

Go to https://foundation.zurb.com/sites/docs/dropdown.html
Inspect dropdowns, they have aria-labelledby attribute but buttons doesn't have this id.

Your Environment

Affects current foundation version 6.5

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • There are no other issues similar to this one.
  • The issue title and template are correctly filled.
silenceway referenced this issue Nov 1, 2018
@ncoden
fix: fix dropdown aria-labelledby from its anchor id
8bad6ed 
Introduced in #10360 (36521fb)
Closes #10627
@silenceway silenceway mentioned this issue Nov 1, 2018
Closed
ncoden added a commit to ncoden/foundation-sites that referenced this issue Nov 1, 2018
@ncoden
fix: ensure Dropdown aria-labelledby to have an ID foundation#11572
6cd5944 
Closes foundation#11572
@ncoden ncoden mentioned this issue Nov 1, 2018
Merged
9 tasks
ncoden added a commit to ncoden/foundation-sites that referenced this issue Nov 1, 2018
@ncoden
fix: ensure Dropdown aria-labelledby to have an ID foundation#11572
5ddb04b 
Closes foundation#11572
@ncoden
Copy link
Contributor

ncoden commented Nov 1, 2018

See #11573

@ncoden ncoden added this to the 6.5.1 milestone Nov 1, 2018
ncoden added a commit that referenced this issue Nov 2, 2018
@ncoden
Merge pull request #11573 from ncoden/fix/dropdown-aria-missing-id-11572
3cb5646 
fix: ensure Dropdown aria-labelledby to have an ID #11572
ncoden added a commit that referenced this issue Nov 12, 2018
@ncoden
Use pull request #11573 from ncoden/fix/dropdown-aria-missing-id-1157…
8951166 
…2 for v6.5.0

5ddb04b fix: ensure Dropdown aria-labelledby to have an ID #11572
adce391 fix: revert inadvertent substitution of Dropdown "aria-labelledby" attribute

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden added a commit to ncoden/foundation-sites that referenced this issue Nov 12, 2018
@ncoden
Use pull request foundation#11573 from ncoden/fix/dropdown-aria-missi…
d6ed541 
…ng-id-11572 for v6.5.1

5ddb04b fix: ensure Dropdown aria-labelledby to have an ID foundation#11572
adce391 fix: revert inadvertent substitution of Dropdown "aria-labelledby" attribute

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this issue Nov 12, 2018
Merged
11 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Dropdown PR open
Projects
None yet
Milestone
6.5.1
Development

Successfully merging a pull request may close this issue.

fix: ensure Dropdown aria-labelledby to have an ID #11572 ncoden/foundation-sites
2 participants
@silenceway @ncoden