-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sort Sass components in categories #10856
chore: sort Sass components in categories #10856
Conversation
Sort CSS includes in the following categories: 1. Global styles 2. Generic components (controls and HTML-oriented components) 3. Basic components (components with enclosed layout styles) 4. Containers (components with side-effects on internal layout) 5. Layout (components with side-effects on external layout) 6. Helpers (highly specific and non-inheritable classes)
@colin-marshall @brettsmason Could you review this ? |
I checked all component and everything looks fine. |
@ncoden I like this better, but it seems the categories themselves would be more organized if it could be sorted alphabetically when dependencies don't matter. For example, I think |
@colin-marshall You are right. I'll change that. |
…onents-by-specificity
Note: * forms & typograph has been moved to global styles, as they apply properties on tags and not custom components * Accodtion/Drilldrown/Dropdown menus must be after `menu`
I resolved conflicts with |
54074cd
to
fecf67d
Compare
…onents-by-specificity
Closes:
Changes: Sort CSS includes in the following categories: