-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop normalize-scss
and upgrade to normalize.css v8.0.0
#11086
Conversation
`normalize-scss` is not maintained and actually pollute the Sass namespace. Move back to a as-hard-to-maintain approach with a Sass mixin hosting the normalize.css code. Note: `/* */` comments where replaced by `//` comments to not being output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far but we may have to check all exaples for layout changes due to the new normalize version.
Sidenote: https://github.com/zurb/foundation-sites/blob/ab4beb10bb91034c76dcf0457c105766d8ef8b47/scss/components/_reveal.scss#L42-L50 is output before the other styles. Should we move this to another place or is it still needed (there)? See the generated foundation.css file at the very top. |
@DanielRuf This is related to #10856 and components sorting. It's at the top because placeholders code is generated (if used) where it is placed. The problem in this case is that it is used inside a modifier mixin ( So, it seems it's part of an "initialization" step (after import and before each component generation) that does not exist in our architecture (and most SCSS architectures). That's too deep for v6 but a good challenge for v7 :). It's does not cause any bugs, right ? |
It adds the styles even if none of the mixins is used so it may cause issues. |
hmm... No it shouldn't. That's a placeholder, it generate styles only if used. And empty breakpoints are removed by Sass. Did you test it ? |
This is not the case. The import statement alone adds this directly. See #11087 |
Did you test it ? |
At least it makes not much sense to add it up there. The other code in my PR works too. Deduplication is done by libsass. |
Anyway, we should check that the side effects of the normalize update on the components. |
Probably it was added because the docs and default foundation.scss use it with the include statement. |
…6.5.0 6e72435 chore: drop `normalize-scss` and upgrade to normalize.css v8.0.0 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
normalize-scss
is not maintained and actually pollute the Sass namespace. Move back to a as-hard-to-maintain approach with a Sass mixin hosting the normalize.css code.Note:
/* */
comments where replaced by//
comments to not being output.Changes
normalize-scss
dependenciesvendor/normalize
SCSS file hosting the normalize v8.0.0 CSS inside a mixin./vendor
folder being ignored by gitCloses #11015
Replaces #11016
Replaces #11072