Fix: dropdown menu event names in docs #10929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyEnglert
changed the title
ncoden
approved these changes
Feb 11, 2018
There was a problem hiding this comment.
This is our Git workflow for now. Even if the change is "in the code", this is considered as a Documentation change, so it's good for master.
But I agree with you that this is confusing. As said in private:
this is not a good practice at all.
mastershould be safe and in theory contains only new releases.
LGTM 👍 Good job.
|
Do we still need this branch? |
|
No ;) |
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…ents for v6.5.0 ec24cb7 Fix: dropdown menu event names Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10563
I'll admit, I'm a bit confused on exactly how to submit this PR. Because to fix the event name in the docs, it looks like we have to edit it in the code.
@ncoden - gonna need your help here. :)