fix generated event name

[DanielRuf]

As a sidenote, using the title for event names is not a great idea. We should use some variable fn-name or similar.

[ncoden]

I don't get it. What is the link between the doc title and the event names ?

[DanielRuf]

I don't get it. What is the link between the doc title and the event names ?

Well, run npm run deploy:docs and take a look at the build/drilldown-menu.html file.

[DanielRuf]

See formatJsEventName at https://github.com/zurb/foundation-docs/blob/master/lib/handlebars/javascript.js

[DanielRuf]

The change is already done in develop but not master where the current docs live and so the docs are atill wrong.

[DanielRuf]

Also see

#9151

#10555

[DanielRuf]

I hereby propose to add another frontmatter variable which is used if it is set. But probably in another PR.

[JeremyEnglert]

I thought the names were generated from the inline names/comments. Such as here: https://github.com/zurb/foundation-sites/blob/1c6ce2d69e976b8d0ead214c2b2619548466c858/js/foundation.drilldown.js#L302

If this isn't the case, the recently merged PR (#10929) isn't correct.

[DanielRuf]

I thought the names were generated from the inline names/comments. Such as here:

Unfortunately no.

[DanielRuf]

is the current status.

[DanielRuf]

And https://github.com/zurb/foundation-docs/blob/master/templates/partials/javascript-reference.hbs#L107 => https://github.com/zurb/foundation-docs/blob/master/lib/handlebars/javascript.js#L109-L111

[JeremyEnglert]

Eeeek. Definitely something we need to address in F7. Contributing to the docs should be one of the easier things to do.

Waiting for feedback from @ncoden, as we may have to address previous PRs as well.

[ncoden]

I'm investigating for a solution a bit cleaner.

[ncoden]

See foundation/foundation-docs#24
This seems resolved with that patch, so I close this PR.

[ncoden]

See also: #10933